Merge pull request #375 from nimblehq/feature/370-migrate-compose-permission-request-logic

[#370] [Compose] Migrate to the new permission request logic

Author: toby-thanathip

sample-compose/app/build.gradle.kts

@@ -133,7 +133,7 @@ dependencies {
     implementation("org.jetbrains.kotlin:kotlin-stdlib:${Versions.KOTLIN_VERSION}")
     implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:${Versions.KOTLINX_COROUTINES_VERSION}")
 
-    implementation("com.markodevcic:peko:${Versions.PEKO_VERSION}")
+    implementation("com.google.accompanist:accompanist-permissions:${Versions.ACCOMPANIST_PERMISSIONS_VERSION}")
 
     kapt("com.google.dagger:hilt-compiler:${Versions.HILT_VERSION}")
 

sample-compose/app/src/main/AndroidManifest.xml

@@ -3,7 +3,6 @@
     package="co.nimblehq.sample.compose">
 
     <uses-permission android:name="android.permission.INTERNET" />
-    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
     <uses-permission android:name="android.permission.CAMERA" />
 
     <application

sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/HomeScreen.kt

@@ -1,5 +1,6 @@
 package co.nimblehq.sample.compose.ui.screens.home
 
+import android.Manifest.permission.*
 import android.widget.Toast
 import androidx.compose.foundation.layout.*
 import androidx.compose.material.CircularProgressIndicator
@@ -17,6 +18,7 @@ import co.nimblehq.sample.compose.ui.AppDestination
 import co.nimblehq.sample.compose.ui.screens.AppBar
 import co.nimblehq.sample.compose.ui.theme.ComposeTheme
 import co.nimblehq.sample.compose.ui.userReadableMessage
+import com.google.accompanist.permissions.*
 
 @Composable
 fun HomeScreen(
@@ -37,13 +39,42 @@ fun HomeScreen(
     val showLoading: IsLoading by viewModel.showLoading.collectAsState()
     val uiModels: List<UiModel> by viewModel.uiModels.collectAsState()
 
+    CameraPermission()
+
     HomeScreenContent(
         uiModels = uiModels,
         showLoading = showLoading,
         onItemClick = viewModel::navigateToSecond
     )
 }
 
+/**
+ * [CameraPermission] needs to be separate from [HomeScreenContent] to avoid re-composition
+ */
+@OptIn(ExperimentalPermissionsApi::class)
+@Composable
+private fun CameraPermission() {
+    val context = LocalContext.current
+    val cameraPermissionState = rememberPermissionState(CAMERA)
+    if (cameraPermissionState.status.isGranted) {
+        Toast.makeText(context, "${cameraPermissionState.permission} granted", Toast.LENGTH_SHORT).show()
+    } else {
+        if (cameraPermissionState.status.shouldShowRationale) {
+            Toast.makeText(context, "${cameraPermissionState.permission} needs rationale", Toast.LENGTH_SHORT).show()
+        } else {
+            Toast.makeText(
+                context,
+                "Request cancelled, missing permissions in manifest or denied permanently",
+                Toast.LENGTH_SHORT
+            ).show()
+        }
+
+        LaunchedEffect(Unit) {
+            cameraPermissionState.launchPermissionRequest()
+        }
+    }
+}
+
 @Composable
 private fun HomeScreenContent(
     uiModels: List<UiModel>,

sample-compose/buildSrc/src/main/java/Versions.kt

@@ -9,6 +9,7 @@ object Versions {
     const val ANDROID_VERSION_NAME = "3.15.0"
 
     // Dependencies (Alphabet sorted)
+    const val ACCOMPANIST_PERMISSIONS_VERSION = "0.28.0"
     const val ANDROID_COMMON_KTX_VERSION = "0.1.1"
     const val ANDROID_CRYPTO_VERSION = "1.0.0"
     const val ANDROIDX_CORE_KTX_VERSION = "1.9.0"
@@ -33,8 +34,6 @@ object Versions {
 
     const val OKHTTP_VERSION = "4.9.1"
 
-    const val PEKO_VERSION = "2.1.2"
-
     const val RETROFIT_VERSION = "2.9.0"
 
     const val TIMBER_LOG_VERSION = "4.7.1"

template-compose/app/build.gradle.kts

@@ -133,7 +133,7 @@ dependencies {
     implementation("org.jetbrains.kotlin:kotlin-stdlib:${Versions.KOTLIN_VERSION}")
     implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:${Versions.KOTLINX_COROUTINES_VERSION}")
 
-    implementation("com.markodevcic:peko:${Versions.PEKO_VERSION}")
+    implementation("com.google.accompanist:accompanist-permissions:${Versions.ACCOMPANIST_PERMISSIONS_VERSION}")
 
     kapt("com.google.dagger:hilt-compiler:${Versions.HILT_VERSION}")
 

template-compose/buildSrc/src/main/java/Versions.kt

@@ -9,6 +9,7 @@ object Versions {
     const val ANDROID_VERSION_NAME = "1.0.0"
 
     // Dependencies (Alphabet sorted)
+    const val ACCOMPANIST_PERMISSIONS_VERSION = "0.28.0"
     const val ANDROID_COMMON_KTX_VERSION = "0.1.1"
     const val ANDROID_CRYPTO_VERSION = "1.0.0"
     const val ANDROIDX_CORE_KTX_VERSION = "1.9.0"
@@ -33,8 +34,6 @@ object Versions {
 
     const val OKHTTP_VERSION = "4.9.1"
 
-    const val PEKO_VERSION = "2.1.2"
-
     const val RETROFIT_VERSION = "2.9.0"
 
     const val TIMBER_LOG_VERSION = "4.7.1"