[#639] Resolve comments

Author: thinh2k1310

template/Modules/Data/Sources/AppConfig/AnyCodingKey.swift

@@ -28,4 +28,4 @@ public struct AnyCodingKey: CodingKey, Hashable {
             self.init(stringValue: base.stringValue)
         }
     }
-}
+}

template/Modules/Data/Sources/AppConfig/AppConfig.swift

@@ -121,4 +121,4 @@ extension AppConfig {
         #endif
         return true
     }
-}
+}

template/Modules/Data/Sources/AppConfig/AppDefaultConfig.swift

@@ -7,7 +7,7 @@ import Foundation
 /// Wraps an arbitrary key-value dictionary to be loaded as Firebase Remote Config defaults.
 public struct AppDefaultConfig: Encodable {
 
-    public var configs: [AnyCodingKey: any Encodable]
+    public let configs: [AnyCodingKey: any Encodable]
 
     public init(configs: [AnyCodingKey: any Encodable] = [:]) {
         self.configs = configs
@@ -45,4 +45,4 @@ private struct AnyEncodable: Encodable {
     func encode(to encoder: any Encoder) throws {
         try value.encode(to: encoder)
     }
-}
+}

template/Modules/Data/Sources/AppConfig/ExampleAppConfiguration.swift

@@ -46,7 +46,7 @@ public func createExampleAppConfig() -> AppConfig<ExampleAppConfiguration> {
 
     let configMapper: (RemoteConfigDecoder) -> ExampleAppConfiguration = { decoder in
         ExampleAppConfiguration(
-            isFeatureEnabled: decoder.decodeBool(forKey: ExampleConfigKey.isFeatureEnabled.rawValue),
+            isFeatureEnabled: decoder.decodeBool(forKey: ExampleConfigKey.isFeatureEnabled.rawValue) ?? false,
             maxRetryCount: decoder.decodeNumber(forKey: ExampleConfigKey.maxRetryCount.rawValue)?.intValue ?? 3,
             apiTimeout: decoder.decodeNumber(forKey: ExampleConfigKey.apiTimeout.rawValue)?.doubleValue ?? 30.0,
             welcomeMessage: decoder.decodeString(forKey: ExampleConfigKey.welcomeMessage.rawValue) ?? "Welcome"
@@ -58,4 +58,4 @@ public func createExampleAppConfig() -> AppConfig<ExampleAppConfiguration> {
         initialConfig: initialConfig,
         configMapper: configMapper
     )
-}
+}

template/Modules/Data/Sources/AppConfig/FirebaseRemoteConfigSource.swift

@@ -30,7 +30,11 @@ public final class FirebaseRemoteConfigSource: RemoteConfigSource {
 
     private let remoteConfig: any RemoteConfigInterface
 
-    public convenience init(remoteConfig: RemoteConfig = RemoteConfig.remoteConfig()) {
+    public convenience init() {
+        self.init(config: RemoteConfig.remoteConfig())
+    }
+    
+    public convenience init(remoteConfig: RemoteConfig) {
         self.init(config: remoteConfig)
     }
 
@@ -53,7 +57,7 @@ public final class FirebaseRemoteConfigSource: RemoteConfigSource {
     public func value(forKey key: String) async -> RemoteConfigStoredValue? {
         let (data, source) = remoteConfig.configEntry(forKey: key)
 
-        guard source != .static || !data.isEmpty else {
+        guard !data.isEmpty, source != .static else {
             return nil
         }
 

template/Modules/Data/Sources/AppConfig/RemoteConfigDecoder.swift

@@ -54,14 +54,24 @@ public struct RemoteConfigDecoder {
         return value
     }
 
-    public func decodeBool(forKey keyString: String) -> Bool {
-        let value = remoteConfig[keyString].boolValue
+    public func decodeBool(forKey keyString: String) -> Bool? {
+        let configValue = remoteConfig[keyString]
+        guard !configValue.dataValue.isEmpty else {
+            log("No bool value for key: \(keyString)")
+            return nil
+        }
+        let value = configValue.boolValue
         log("Decoded bool for \(keyString): \(value)")
         return value
     }
 
     public func decodeNumber(forKey keyString: String) -> NSNumber? {
-        let value = remoteConfig[keyString].numberValue
+        let configValue = remoteConfig[keyString]
+        guard !configValue.dataValue.isEmpty else {
+            log("No number value for key: \(keyString)")
+            return nil
+        }
+        let value = configValue.numberValue
         log("Decoded number for \(keyString): \(value)")
         return value
     }

template/Modules/Data/Sources/Extensions/Container+Data.swift

@@ -47,14 +47,10 @@ extension Container {
             .singleton
     }
 
-    public var firebaseRemoteConfigSource: Factory<FirebaseRemoteConfigSource> {
+    public var firebaseRemoteConfigSource: Factory<RemoteConfigSource> {
         self { FirebaseRemoteConfigSource() }.singleton
     }
 
-    public var remoteConfigRepository: Factory<RemoteConfigRepository> {
-        self { DefaultRemoteConfigRepository(source: self.firebaseRemoteConfigSource()) }.singleton
-    }
-
     /// Example AppConfig factory. Replace with your app-specific configuration.
     public var exampleAppConfig: Factory<AppConfig<ExampleAppConfiguration>> {
         self { createExampleAppConfig() }.singleton