[#698] Resolve comment

Author: thinh2k1310

template/Modules/Data/Sources/Repositories/RatingPromptStorage.swift

@@ -1,16 +1,15 @@
 import Domain
 import Foundation
 
-final class RatingPromptStorage: RatingPromptStorageProtocol, @unchecked Sendable {
+actor RatingPromptStorage: RatingPromptStorageProtocol {
 
     private let userDefaultsManager: UserDefaultsManagerProtocol
-    private let lock = NSLock()
 
     init(userDefaultsManager: UserDefaultsManagerProtocol) {
         self.userDefaultsManager = userDefaultsManager
     }
 
-    func getRatingPromptData() -> RatingPromptData {
+    func getRatingPromptData() async -> RatingPromptData {
         let appLaunchCount = userDefaultsManager.getIntValue(for: UserDefaultsKey.ratingPromptAppLaunchCount.rawValue)
         let firstLaunchDateData = userDefaultsManager.getDataValue(for: UserDefaultsKey.ratingPromptFirstLaunchDate.rawValue)
         let lastPromptedVersion = userDefaultsManager.getStringValue(for: UserDefaultsKey.ratingPromptLastPromptedVersion.rawValue)
@@ -29,10 +28,7 @@ final class RatingPromptStorage: RatingPromptStorageProtocol, @unchecked Sendabl
         )
     }
 
-    func recordAppLaunch() {
-        lock.lock()
-        defer { lock.unlock() }
-        
+    func recordAppLaunch() async {
         let currentCount = userDefaultsManager.getIntValue(for: UserDefaultsKey.ratingPromptAppLaunchCount.rawValue)
         userDefaultsManager.set(currentCount + 1, for: UserDefaultsKey.ratingPromptAppLaunchCount.rawValue)
 
@@ -46,27 +42,24 @@ final class RatingPromptStorage: RatingPromptStorageProtocol, @unchecked Sendabl
         userDefaultsManager.synchronize()
     }
 
-    func recordSignificantEvent() {
-        lock.lock()
-        defer { lock.unlock() }
-        
+    func recordSignificantEvent() async {
         let currentCount = userDefaultsManager.getIntValue(for: UserDefaultsKey.ratingPromptSignificantEventCount.rawValue)
         userDefaultsManager.set(currentCount + 1, for: UserDefaultsKey.ratingPromptSignificantEventCount.rawValue)
         userDefaultsManager.synchronize()
     }
 
-    func recordPromptShown(for appVersion: String) {
+    func recordPromptShown(for appVersion: String) async {
         userDefaultsManager.set(appVersion, for: UserDefaultsKey.ratingPromptLastPromptedVersion.rawValue)
         userDefaultsManager.synchronize()
     }
 
-    func resetCounters() {
+    func resetCounters() async {
         userDefaultsManager.set(0, for: UserDefaultsKey.ratingPromptAppLaunchCount.rawValue)
         userDefaultsManager.set(0, for: UserDefaultsKey.ratingPromptSignificantEventCount.rawValue)
         userDefaultsManager.synchronize()
     }
 
-    func clearAllData() {
+    func clearAllData() async {
         let keys = [
             UserDefaultsKey.ratingPromptAppLaunchCount.rawValue,
             UserDefaultsKey.ratingPromptFirstLaunchDate.rawValue,

template/Modules/Data/Sources/Services/DefaultRatingPromptPresenter.swift

@@ -7,15 +7,14 @@ import StoreKit
 
 // MARK: - DefaultRatingPromptPresenter
 
-public final class DefaultRatingPromptPresenter: RatingPromptPresenterProtocol, @unchecked Sendable {
+public actor DefaultRatingPromptPresenter: RatingPromptPresenterProtocol {
 
     private let storeReviewController: any StoreReviewControllerProtocol
 
     public init(storeReviewController: any StoreReviewControllerProtocol) {
         self.storeReviewController = storeReviewController
     }
 
-    @MainActor
     public func show() async -> Bool {
         return await storeReviewController.requestReview()
     }

template/Modules/Domain/Sources/Interfaces/RatingPromptPresenterProtocol.swift

@@ -4,6 +4,5 @@
 
 public protocol RatingPromptPresenterProtocol: Sendable {
 
-    @MainActor
     func show() async -> Bool
 }

template/Modules/Domain/Sources/Interfaces/RatingPromptStorageProtocol.swift

@@ -4,20 +4,20 @@ import Foundation
 public protocol RatingPromptStorageProtocol: Sendable {
 
     /// Retrieves current rating prompt data
-    func getRatingPromptData() -> RatingPromptData
+    func getRatingPromptData() async -> RatingPromptData
 
     /// Increments app launch count and sets first launch date if needed
-    func recordAppLaunch()
+    func recordAppLaunch() async
 
     /// Increments significant event count
-    func recordSignificantEvent()
+    func recordSignificantEvent() async
 
     /// Records that user was prompted for rating on current version
-    func recordPromptShown(for appVersion: String)
+    func recordPromptShown(for appVersion: String) async
 
     /// Resets tracking counters (typically called after prompt is shown)
-    func resetCounters()
+    func resetCounters() async
 
     /// Clears all rating prompt related data
-    func clearAllData()
+    func clearAllData() async
 }

template/Modules/Domain/Sources/UseCases/RequestRatingPromptUseCase.swift

@@ -35,15 +35,15 @@ public struct RequestRatingPromptUseCase: RequestRatingPromptUseCaseProtocol {
 
     @MainActor
     public func callAsFunction(configuration: RatingPromptConfiguration) async -> Bool {
-        guard shouldShowRatingPromptUseCase(configuration: configuration) else { return false }
+        guard await shouldShowRatingPromptUseCase(configuration: configuration) else { return false }
 
         let didRequestPrompt = await presenter.show()
         guard didRequestPrompt else { return false }
 
-        storage.recordPromptShown(for: currentVersion())
+        await storage.recordPromptShown(for: currentVersion())
 
         if configuration.resetCounterAfterPrompt {
-            storage.resetCounters()
+            await storage.resetCounters()
         }
 
         return true

template/Modules/Domain/Sources/UseCases/ShouldShowRatingPromptUseCase.swift

@@ -9,7 +9,7 @@ public protocol ShouldShowRatingPromptUseCaseProtocol: Sendable {
     /// Determines if rating prompt should be shown based on configuration rules
     /// - Parameter configuration: Rules for determining eligibility
     /// - Returns: True if prompt should be shown
-    func callAsFunction(configuration: RatingPromptConfiguration) -> Bool
+    func callAsFunction(configuration: RatingPromptConfiguration) async -> Bool
 }
 
 public struct ShouldShowRatingPromptUseCase: ShouldShowRatingPromptUseCaseProtocol, Sendable {
@@ -25,8 +25,8 @@ public struct ShouldShowRatingPromptUseCase: ShouldShowRatingPromptUseCaseProtoc
         self.currentVersion = currentVersion
     }
 
-    public func callAsFunction(configuration: RatingPromptConfiguration) -> Bool {
-        let data = storage.getRatingPromptData()
+    public func callAsFunction(configuration: RatingPromptConfiguration) async -> Bool {
+        let data = await storage.getRatingPromptData()
 
         guard !data.hasBeenPromptedForCurrentVersion(currentVersion) else {
             return false