Skip to content

Commit 9fec779

Browse files
committed
TST: Refactor tests, update request import
1 parent 17344e2 commit 9fec779

File tree

2 files changed

+8
-40
lines changed

2 files changed

+8
-40
lines changed

migas/tests/test_operations.py

+3-35
Original file line numberDiff line numberDiff line change
@@ -25,30 +25,17 @@
2525
today = today.strftime('%Y-%m-%d')
2626

2727

28-
def test_operations(setup_migas):
29-
_test_add_breakcrumb()
30-
# add delay to ensure server has updated
31-
time.sleep(2)
32-
_test_get_usage()
33-
34-
def _test_add_breakcrumb():
28+
def test_database_io(setup_migas):
3529
res = add_breadcrumb(test_project, __version__)
36-
assert res['success'] is True
37-
3830
# ensure kwargs can be submitted
3931
res = add_breadcrumb(test_project, __version__, language='cpython', platform='win32')
40-
assert res['success'] is True
41-
42-
# validation should happen instantly
32+
# this breadcrumb is not valid
4333
res = add_breadcrumb(test_project, __version__, status='wtf')
44-
assert res['success'] is False
4534

46-
def _test_get_usage():
47-
"""This test requires `_test_add_breadcrumb()` to be run before."""
4835
res = get_usage(test_project, start=today)
4936
assert res['success'] is True
5037
all_usage = res['hits']
51-
assert all_usage > 0
38+
assert all_usage == 2
5239

5340
res = get_usage(test_project, start=today, unique=True)
5441
assert res['success'] is True
@@ -64,25 +51,6 @@ def _test_get_usage():
6451
assert res['hits'] == 0
6552

6653

67-
def test_add_project(setup_migas):
68-
res = add_project(test_project, __version__)
69-
assert res['success'] is True
70-
latest = res['latest_version']
71-
assert latest
72-
73-
# ensure kwargs can be submitted
74-
res = add_project(test_project, __version__, language='cpython', platform='win32')
75-
assert res['success'] is True
76-
assert res['latest_version'] == latest
77-
# should be cached since we just checked the version
78-
assert res['cached'] is True
79-
80-
# illegal queries should fail
81-
res = add_project(test_project, __version__, status='wtf')
82-
assert res['success'] is False
83-
assert res['latest_version'] is None
84-
85-
8654
def test_check_project(setup_migas):
8755
res = check_project(test_project, __version__)
8856
assert res['success'] is True

migas/tests/test_request.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import pytest
22

3-
from migas.request import request
3+
from migas.request import _request
44

55
GET_URL = 'https://httpbin.org/get'
66
GET_COMPRESSED_URL = 'https://httpbingo.org/get'
@@ -15,22 +15,22 @@
1515
]
1616
)
1717
def test_request_get(method, url, query):
18-
status, res = request(url, query=query, method=method)
18+
status, res = _request(url, query=query, method=method)
1919
assert status == 200
2020
assert res
2121

2222

2323
def test_timeout(monkeypatch):
24-
status, res = request(GET_URL, timeout=0.00001, method="GET")
24+
status, res = _request(GET_URL, timeout=0.00001, method="GET")
2525
assert status == 408
2626
assert res['errors']
2727

2828
monkeypatch.setenv('MIGAS_TIMEOUT', '0.000001')
29-
status, res = request(GET_URL, method="GET")
29+
status, res = _request(GET_URL, method="GET")
3030
assert status == 408
3131
assert res['errors']
3232

3333
monkeypatch.delenv('MIGAS_TIMEOUT')
34-
status, res = request(GET_URL, method="GET")
34+
status, res = _request(GET_URL, method="GET")
3535
assert status == 200
3636
assert res

0 commit comments

Comments
 (0)