STY: Add implicit concatenation and pytest style checks

Author: effigies

pyproject.toml

@@ -157,6 +157,8 @@ extend-select = [
   "EXE",
   "FA",
   "ISC",
+  "ICN",
+  "PT",
 ]
 
 [tool.ruff.flake8-quotes]

smriprep/conftest.py

@@ -1,6 +1,6 @@
 import os
 
-import numpy
+import numpy as np
 import pytest
 
 from smriprep.data import load_resource
@@ -9,8 +9,8 @@
 
 
 @pytest.fixture(autouse=True)
-def populate_namespace(doctest_namespace, tmp_path):
+def _populate_namespace(doctest_namespace, tmp_path):
     doctest_namespace['os'] = os
-    doctest_namespace['np'] = numpy
+    doctest_namespace['np'] = np
     doctest_namespace['load'] = load_resource
     doctest_namespace['testdir'] = tmp_path

smriprep/utils/tests/test_misc.py

@@ -36,7 +36,7 @@ def _gen_fsdir(tmp_path, isrunning):
 
 
 @pytest.mark.parametrize(
-    'isrunning,mtime_tol,error',
+    ('isrunning', 'mtime_tol', 'error'),
     [
         (False, 86400, None),
         (True, 86400, RuntimeError),

smriprep/workflows/tests/test_anatomical.py

@@ -44,7 +44,7 @@
 
 
 @pytest.fixture(scope='module', autouse=True)
-def quiet_logger():
+def _quiet_logger():
     import logging
 
     logger = logging.getLogger('nipype.workflow')
@@ -59,7 +59,7 @@ def bids_root(tmp_path_factory):
     base = tmp_path_factory.mktemp('base')
     bids_dir = base / 'bids'
     generate_bids_skeleton(bids_dir, BASE_LAYOUT)
-    yield bids_dir
+    return bids_dir
 
 
 @pytest.mark.parametrize('freesurfer', [True, False])