Merge branch 'sourcegraph:main' into main

Author: nipundev

.bazeliskrc

@@ -1,2 +1,2 @@
 BAZELISK_BASE_URL=https://github.com/aspect-build/aspect-cli/releases/download
-USE_BAZEL_VERSION=aspect/5.5.4
+USE_BAZEL_VERSION=aspect/5.8.5

.bazelrc

@@ -47,3 +47,7 @@ test:go-verbose-test --test_env=GO_TEST_WRAP_TESTV=1
 # .aspect/bazelrc/correctness.bazelrc sets this, but this breaks with a lot of Go external deps, so
 # we instead disable it.
 common --noincompatible_disallow_empty_glob
+
+# Ensure clippy runs for rust targets
+build --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect
+build --output_groups=+clippy_checks

.bazelversion

@@ -1 +1 @@
-6.1.1
+7.0.0-pre.20231011.2

.browserslistrc

@@ -5,6 +5,10 @@ set -e
 # Create the folder for annotations
 mkdir -p ./annotations/
 
+if [[ "$BUILDKITE_AGENT_META_DATA_QUEUE" =~ aspect-.* ]]; then
+    exit 0
+fi
+
 # asdf setup
 # ----------
 if [[ "$BUILDKITE_AGENT_META_DATA_QUEUE" != "bazel" && "$BUILDKITE_AGENT_META_DATA_QUEUE" != "macos" ]]; then

.buildkite/hooks/pre-command

@@ -46,21 +46,6 @@ pnpm-debug.log
 
 /cmd/frontend/internal/graphqlbackend/node_modules
 
-/ui/artifacts
-/ui/node_modules
-/ui/assets/_goTemplates.js
-/ui/assets/analytics.js
-/ui/assets/bundle.js
-/ui/assets/bundle.css
-/ui/assets/sourcebox.js
-/ui/assets/sourcebox.css
-/ui/assets/test.js
-/ui/assets/test.css
-/ui/assets/vs
-/ui/assets/*.html
-/ui/assets/*.map
-/ui/assets/extension
-/ui/.tmp
 *.json.actual
 
 eb-bundle.zip

.buildkite/pipeline.async.yml

@@ -1,6 +1,30 @@
 // @ts-check
 
+// Use faster experimental way of doing multi-project TypeScript linting. See
+// https://github.com/typescript-eslint/typescript-eslint/pull/6754.
+process.env.TYPESCRIPT_ESLINT_EXPERIMENTAL_TSSERVER = 'true'
+
 const config = {
+  root: true,
+  ignorePatterns: [
+    '**/graphql-operations.ts',
+    '**/node_modules/**',
+    'out/',
+    'dist/',
+    'src/schema/*',
+    'graphql-operations.ts',
+    'GH2SG.bookmarklet.js',
+    '**/vendor/*.js',
+    'svelte.config.js',
+    'vite.config.ts',
+    'playwright.config.ts',
+    '.vscode-test',
+    '**/*.json',
+    '**/*.d.ts',
+    'eslint-relative-formatter.js',
+    'typedoc.js',
+    'bundlesize.config.js',
+  ],
   extends: ['@sourcegraph/eslint-config', 'plugin:storybook/recommended'],
   env: {
     browser: true,
@@ -13,8 +37,8 @@ const config = {
     ecmaFeatures: {
       jsx: true,
     },
-    EXPERIMENTAL_useSourceOfProjectReferenceRedirect: true,
-    project: __dirname + '/tsconfig.eslint.json',
+    EXPERIMENTAL_projectService: true,
+    project: __dirname + '/tsconfig.all.json',
   },
   settings: {
     react: {
@@ -52,6 +76,15 @@ const config = {
     ],
     // This converts 'import {type foo} from ...' to 'import type {foo} from ...'
     '@typescript-eslint/no-import-type-side-effects': ['warn'],
+
+    // These rules are very slow on-save.
+    '@typescript-eslint/no-unsafe-assignment': 'off',
+    '@typescript-eslint/unbound-method': 'off',
+    '@typescript-eslint/no-misused-promises': 'off',
+    '@typescript-eslint/no-unnecessary-qualifier': 'off',
+    '@typescript-eslint/no-unused-vars': 'off', // also duplicated by tsconfig noUnused{Locals,Parameters}
+    'etc/no-deprecated': 'off',
+
     'no-restricted-imports': [
       'error',
       {
@@ -99,6 +132,9 @@ See https://handbook.sourcegraph.com/community/faq#is-all-of-sourcegraph-open-so
               '!@sourcegraph/branded/src/search-ui/experimental',
               '!@sourcegraph/*/src/testing',
               '!@sourcegraph/*/src/stories',
+              '!@sourcegraph/build-config/src/esbuild/*',
+              '!@sourcegraph/build-config/src/*',
+              '!@sourcegraph/testing/src/jestDomMatchers',
             ],
             message:
               'Imports from package internals are banned. Add relevant export to the entry point of the package to import it from the outside world.',
@@ -108,6 +144,11 @@ See https://handbook.sourcegraph.com/community/faq#is-all-of-sourcegraph-open-so
             message:
               "Please don't import stuff from the 'out' directory. It’s generated code. Remove the 'out/' part and you should be good go to.",
           },
+          {
+            group: ['!@sourcegraph/cody-shared/*', '!@sourcegraph/cody-ui/*'],
+            message:
+              "Allowed imports from @sourcegraph/cody-* packages while those packages' APIs are being stabilized.",
+          },
         ],
       },
     ],
@@ -242,7 +283,26 @@ See https://handbook.sourcegraph.com/community/faq#is-all-of-sourcegraph-open-so
       },
     ],
     'import/order': 'off',
-    'etc/no-deprecated': 'off',
+    'unicorn/expiring-todo-comments': 'off',
+
+    // These rules were newly introduced in @sourcegraph/[email protected] and have not yet been
+    // fixed in our existing code.
+    'unicorn/prefer-top-level-await': 'warn',
+    'unicorn/prefer-logical-operator-over-ternary': 'warn',
+    'unicorn/prefer-blob-reading-methods': 'warn',
+    'unicorn/prefer-event-target': 'warn',
+    'etc/throw-error': 'warn',
+    'rxjs/throw-error': 'warn',
+    'prefer-promise-reject-errors': 'warn',
+    '@typescript-eslint/no-redundant-type-constituents': 'warn',
+    '@typescript-eslint/no-unsafe-enum-comparison': 'warn',
+    '@typescript-eslint/prefer-optional-chain': 'warn',
+    '@typescript-eslint/no-duplicate-enum-values': 'warn',
+    '@typescript-eslint/no-floating-promises': 'warn',
+
+    'jsdoc/check-alignment': 'off',
+
+    'unicorn/no-negated-condition': 'off', // this one reduces code readability, should remove it from @sourcegraph/eslint-config too
   },
   overrides: [
     {
@@ -259,11 +319,24 @@ See https://handbook.sourcegraph.com/community/faq#is-all-of-sourcegraph-open-so
       },
     },
     {
-      files: ['**/gulpfile.js', '**/story/**.tsx', '**/story/**.ts', '*.story.tsx'],
+      files: ['**/dev/**/*.ts', '**/story/**.tsx', '**/story/**.ts', '*.story.tsx', 'client/build-config/**'],
+      rules: {
+        'no-console': 'off',
+        'no-sync': 'off',
+      },
+    },
+    {
+      files: ['client/browser/**', 'client/jetbrains/**'],
       rules: {
         'no-console': 'off',
       },
     },
+
+    // client/web
+    {
+      files: ['client/web/src/stores/**.ts', 'client/web/src/__mocks__/zustand.ts'],
+      rules: { 'no-restricted-imports': 'off' },
+    },
   ],
 }