Merge branch 'sourcegraph:main' into main

Author: nipundev

.aspect/bazelrc/ci.sourcegraph.bazelrc

@@ -5,44 +5,47 @@ try-import %workspace%/.aspect/bazelrc/ci.generated.bazelrc
 # Use repo caching for building and testing.
 # Article: https://buildkite.com/blog/how-bazel-built-its-ci-system-on-top-of-buildkite
 # Docs: https://bazel.build/reference/command-line-reference#flag--repository_cache
-build --repository_cache=/home/buildkite/repocache-sourcegraph
+common --repository_cache=/home/buildkite/repocache-sourcegraph
 
 # We need /usr/local/bin
 # TODO(DevX) we should be narrower here.
-build --test_env=PATH
+common --test_env=PATH
 
 # Needed for DB in CI
-build --test_env=PGUSER
-build --test_env=PGSSLMODE
-build --test_env=PGDATABASE
+common --test_env=PGUSER=postgres
+common --test_env=PGPASSWORD=postgres
+common --test_env=PGSSLMODE=disable
+common --test_env=PGDATABASE=postgres
 
 # Allow tests to understand they're running in CI, which forces dbtest to drop database even in case of failures.
 # TODO(JH) we should instead wipe all templates after a job finishes.
-build --test_env=CI
+common --test_env=CI
 
 # Ensure we're not exhausting database connections.
-build --test_env=GOMAXPROCS=10
-build --test_env=TESTDB_MAXOPENCONNS=15
+common --test_env=GOMAXPROCS=10
+common --test_env=TESTDB_MAXOPENCONNS=15
 
 # Needed for E2E
-build --test_env=BUILDKITE
+common --test_env=BUILDKITE
 
 # Needed for mocha tests
 # We have to use the `--define` flag here instead of `--test_env` because
 # the mocha tests target is the build target and it's tested with `build_test`.
-build --define=E2E_HEADLESS=false
-build --define=E2E_SOURCEGRAPH_BASE_URL="http://localhost:7080"
-build --define=DISPLAY=:99
+common --define=E2E_HEADLESS=false
+# if we set this to localhost, chrome will refuse to conenct since local host is in its HTTP Strict Transport Security
+# by setting the loopback address we get passed that
+common --define=E2E_SOURCEGRAPH_BASE_URL="http://127.0.0.1:7080"
+common --define=DISPLAY=:99
 
 # Provides git commit, branch information to build targets like Percy via status file.
 # https://bazel.build/docs/user-manual#workspace-status
-build --workspace_status_command=./dev/bazel_buildkite_stamp_vars.sh
+common --workspace_status_command=./dev/bazel_buildkite_stamp_vars.sh
 
 # temp
-build --test_env=INCLUDE_ADMIN_ONBOARDING=false
+common --test_env=INCLUDE_ADMIN_ONBOARDING=false
 
 # Used for container_structure_tests
-build --test_env=DOCKER_HOST
+common --test_env=DOCKER_HOST
 
 # Used by migration rules
-build --action_env=PGUSER=postgres
+common --action_env=PGUSER=postgres

.aspect/bazelrc/performance.bazelrc

@@ -27,12 +27,3 @@ build --experimental_reuse_sandbox_directories
 # author.
 # Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
 build --nolegacy_external_runfiles
-
-# Some actions are always IO-intensive but require little compute. It's wasteful to put the output
-# in the remote cache, it just saturates the network and fills the cache storage causing earlier
-# evictions. It's also not worth sending them for remote execution.
-# For actions like PackageTar it's usually faster to just re-run the work locally every time.
-# You'll have to look at an execution log to figure out what other action mnemonics you care about.
-# In some cases you may need to patch rulesets to add a mnemonic to actions that don't have one.
-# https://bazel.build/reference/command-line-reference#flag--modify_execution_info
-build --modify_execution_info=PackageTar=+no-remote

.aspect/workflows/bazelrc

@@ -0,0 +1,3 @@
+common --remote_download_minimal
+common --nobuild_runfile_links
+common --noexperimental_reuse_sandbox_directories

.aspect/workflows/config.yaml

@@ -0,0 +1,30 @@
+---
+bazel:
+  rcfiles:
+      - ".aspect/bazelrc/ci.sourcegraph.bazelrc"
+  flags:
+    # This flag is required because otherwise the integration tests fail with `fcmod` Operation not permitted
+    # which is probably related to the launced containers writing to mapped in directories as root and then
+    # when the container exits the files that are left over are root.
+    # TODO(burmudar): launch containers with uid/guid mapped in
+    - --noexperimental_reuse_sandbox_directories
+env:
+    REDIS_CACHE_ENDPOINT: ":6379"
+    GIT_PAGER: ''
+tasks:
+    # Checks that BUILD files are formatted
+    buildifier:
+    # Checks that BUILD file content is up-to-date with sources
+    gazelle:
+        target: //:configure
+        fix_target: //:configure
+    # Checks that all tests are passing
+    test:
+      include_eternal_tests: true
+      targets:
+          - //...
+          - //testing:grpc_backend_integration_test
+          # This target should only really run when on main which we aren't handling. For the time being while we
+          # evaluate Aspect Workflows it is ok
+          # TODO(burmudar): Let this only run on main branch
+          - //testing:codeintel_integration_test

.eslintrc.js

@@ -17,13 +17,19 @@ const config = {
     '**/vendor/*.js',
     'svelte.config.js',
     'vite.config.ts',
+    'vitest.config.ts',
+    'postcss.config.js',
     'playwright.config.ts',
+    'bundlesize.config.js',
+    'prettier.config.js',
+    'svgo.config.js',
     '.vscode-test',
     '**/*.json',
     '**/*.d.ts',
     'eslint-relative-formatter.js',
     'typedoc.js',
-    'bundlesize.config.js',
+    'client/web/dev/**/*',
+    'graphql-schema-linter.config.js',
   ],
   extends: ['@sourcegraph/eslint-config', 'plugin:storybook/recommended'],
   env: {
@@ -37,8 +43,8 @@ const config = {
     ecmaFeatures: {
       jsx: true,
     },
-    EXPERIMENTAL_projectService: true,
-    project: __dirname + '/tsconfig.all.json',
+    EXPERIMENTAL_useProjectService: true,
+    project: true,
   },
   settings: {
     react: {

.github/CODEOWNERS

@@ -37,5 +37,5 @@ T-shirt size estimate: **S**.
 ## Contributors
 
 1. Check out [contributing guidelines](https://github.com/sourcegraph/sourcegraph/blob/main/CONTRIBUTING.md).
-2. Join the Sourcegraph [Community Space](https://srcgr.ph/join-community-space) on Slack and join the `#help` channel where the Sourcegraph team can help you!
+2. Join the Sourcegraph [Community Space](https://srcgr.ph/join-community-space) on Discord where the Sourcegraph team can help you!
 3. Check out [the good first issues board](https://github.com/orgs/sourcegraph/projects/210) to find more curated issues.

.github/ISSUE_TEMPLATE/good_first_issue.md

@@ -33,7 +33,7 @@ jobs:
         with:
           ruby-version: "3.2.2" # Not needed with a .ruby-version file   - uses: actions/setup-ruby@v1
       - uses: actions/setup-go@v2
-        with: { go-version: "1.20" }
+        with: { go-version: "1.21" }
 
 
       - name: Install license_finder

.github/workflows/licenses-check.yml

@@ -13,7 +13,7 @@ jobs:
         with:
           repository: 'sourcegraph/pr-auditor'
       - uses: actions/setup-go@v4
-        with: { go-version: '1.20' }
+        with: { go-version: '1.21' }
 
       - run: './check-pr.sh'
         env:

.github/workflows/pr-auditor.yml

@@ -100,7 +100,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.20.8
+          go-version: 1.21.4
 
       - name: Build and upload macOS
         if: startsWith(matrix.os, 'macos-') == true