Skip to content

Commit 1e80412

Browse files
committed
RF: Removed Opener default_keep_open class attribute - default value is hard
coded in __init__
1 parent 2e1a046 commit 1e80412

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

nibabel/openers.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ class Opener(object):
113113
passed to opening method when `fileish` is str. ``mode``, if not
114114
specified, is `rb`. ``compresslevel``, if relevant, and not specified,
115115
is set from class variable ``default_compresslevel``. ``keep_open``, if
116-
relevant, and not specified, is set from class variable
117-
``default_keep_open``.
116+
relevant, and not specified, is ``False``.
118117
\*\*kwargs : keyword arguments
119118
passed to opening method when `fileish` is str. Change of defaults as
120119
for \*args
@@ -130,9 +129,6 @@ class Opener(object):
130129
default_compresslevel = 1
131130
#: whether to ignore case looking for compression extensions
132131
compress_ext_icase = True
133-
#: hint which tells us whether the file handle will be kept open for
134-
# multiple reads/writes, or just for one-time access.
135-
default_keep_open = False
136132

137133
def __init__(self, fileish, *args, **kwargs):
138134
if self._is_fileobj(fileish):
@@ -153,8 +149,7 @@ def __init__(self, fileish, *args, **kwargs):
153149
kwargs['compresslevel'] = self.default_compresslevel
154150
# Default keep_open hint
155151
if 'keep_open' in arg_names:
156-
if 'keep_open' not in kwargs:
157-
kwargs['keep_open'] = self.default_keep_open
152+
kwargs.setdefault('keep_open', False)
158153
# Clear keep_open hint if it is not relevant for the file type
159154
else:
160155
kwargs.pop('keep_open', None)

0 commit comments

Comments
 (0)