STY: Apply ruff/flake8-simplify rule SIM118

SIM118 Use `key in dict` instead of `key in dict.keys()`

Author: DimitriPapadopoulos

Diff for: nipype/interfaces/afni/model.py

@@ -636,7 +636,7 @@ def _parse_inputs(self, skip=None):
     def _list_outputs(self):
         outputs = self.output_spec().get()
 
-        for key in outputs.keys():
+        for key in outputs:
             if isdefined(self.inputs.get()[key]):
                 outputs[key] = os.path.abspath(self.inputs.get()[key])
 
@@ -722,7 +722,7 @@ class Synthesize(AFNICommand):
     def _list_outputs(self):
         outputs = self.output_spec().get()
 
-        for key in outputs.keys():
+        for key in outputs:
             if isdefined(self.inputs.get()[key]):
                 outputs[key] = os.path.abspath(self.inputs.get()[key])
 

Diff for: nipype/interfaces/afni/utils.py

@@ -234,7 +234,7 @@ def aggregate_outputs(self, runtime=None, needed_outputs=None):
             m = re.search(pattern, line)
             if m:
                 d = m.groupdict()
-                outputs.trait_set(**{k: int(d[k]) for k in d.keys()})
+                outputs.trait_set(**{k: int(d[k]) for k in d})
         return outputs
 
 

Diff for: nipype/interfaces/base/specs.py

@@ -383,7 +383,7 @@ def __deepcopy__(self, memo):
         dup_dict = deepcopy(self.trait_get(), memo)
         # access all keys
         for key in self.copyable_trait_names():
-            if key in self.__dict__.keys():
+            if key in self.__dict__:
                 _ = getattr(self, key)
         # clone once
         dup = self.clone_traits(memo=memo)

Diff for: nipype/interfaces/dipy/tests/test_base.py

@@ -109,10 +109,10 @@ def test_create_interface_specs():
     assert new_interface.__name__ == "MyInterface"
     current_params = new_interface().get()
     assert len(current_params) == 4
-    assert "params1" in current_params.keys()
-    assert "params2_files" in current_params.keys()
-    assert "params3" in current_params.keys()
-    assert "out_params" in current_params.keys()
+    assert "params1" in current_params
+    assert "params2_files" in current_params
+    assert "params3" in current_params
+    assert "out_params" in current_params
 
 
 @pytest.mark.skipif(
@@ -184,10 +184,10 @@ def run(self, in_files, param1=1, out_dir="", out_ref="out1.txt"):
     params_in = new_specs().inputs.get()
     params_out = new_specs()._outputs().get()
     assert len(params_in) == 4
-    assert "in_files" in params_in.keys()
-    assert "param1" in params_in.keys()
-    assert "out_dir" in params_out.keys()
-    assert "out_ref" in params_out.keys()
+    assert "in_files" in params_in
+    assert "param1" in params_in
+    assert "out_dir" in params_out
+    assert "out_ref" in params_out
 
     with pytest.raises(ValueError):
         new_specs().run()

Diff for: nipype/interfaces/fsl/model.py

@@ -318,7 +318,7 @@ def _create_ev_files(
 
                     for fconidx in ftest_idx:
                         fval = 0
-                        if con[0] in con_map.keys() and fconidx in con_map[con[0]]:
+                        if con[0] in con_map and fconidx in con_map[con[0]]:
                             fval = 1
                         ev_txt += contrast_ftest_element.substitute(
                             cnum=ftest_idx.index(fconidx) + 1,

Diff for: nipype/interfaces/fsl/tests/test_base.py

@@ -79,7 +79,7 @@ def test_gen_fname(args, desired_name):
     cmd = fsl.FSLCommand(command="junk", output_type="NIFTI_GZ")
     pth = os.getcwd()
     fname = cmd._gen_fname("foo.nii.gz", **args)
-    if "dir" in desired_name.keys():
+    if "dir" in desired_name:
         desired = os.path.join(desired_name["dir"], desired_name["file"])
     else:
         desired = os.path.join(pth, desired_name["file"])

Diff for: nipype/interfaces/spm/model.py

@@ -322,8 +322,8 @@ def _list_outputs(self):
 
         betas = [vbeta.fname[0] for vbeta in spm["SPM"][0, 0].Vbeta[0]]
         if (
-            "Bayesian" in self.inputs.estimation_method.keys()
-            or "Bayesian2" in self.inputs.estimation_method.keys()
+            "Bayesian" in self.inputs.estimation_method
+            or "Bayesian2" in self.inputs.estimation_method
         ):
             outputs["labels"] = os.path.join(pth, f"labels.{outtype}")
             outputs["SDerror"] = glob(os.path.join(pth, "Sess*_SDerror*"))
@@ -332,7 +332,7 @@ def _list_outputs(self):
                 outputs["Cbetas"] = [os.path.join(pth, f"C{beta}") for beta in betas]
                 outputs["SDbetas"] = [os.path.join(pth, f"SD{beta}") for beta in betas]
 
-        if "Classical" in self.inputs.estimation_method.keys():
+        if "Classical" in self.inputs.estimation_method:
             outputs["residual_image"] = os.path.join(pth, f"ResMS.{outtype}")
             outputs["RPVimage"] = os.path.join(pth, f"RPV.{outtype}")
             if self.inputs.write_residuals:

Diff for: nipype/utils/draw_gantt_chart.py

@@ -115,9 +115,9 @@ def _convert_string_to_datetime(datestring):
 
     date_object_node_list: list = list()
     for n in nodes_list:
-        if "start" in n.keys():
+        if "start" in n:
             n["start"] = _convert_string_to_datetime(n["start"])
-        if "finish" in n.keys():
+        if "finish" in n:
             n["finish"] = _convert_string_to_datetime(n["finish"])
         date_object_node_list.append(n)