Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /containers?[containerId={no}&categoryId={no}&groupId={no}] #58

Open
Tracked by #56
kotaaaa opened this issue Dec 3, 2023 · 3 comments
Open
Tracked by #56

GET /containers?[containerId={no}&categoryId={no}&groupId={no}] #58

kotaaaa opened this issue Dec 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@kotaaaa
Copy link
Member

kotaaaa commented Dec 3, 2023

Describe the Enhancement

Add query parameter to GET /users/:userId/containers endpoint

Each parameters are optional.

  • containerId
  • categoryId
  • groupId

Why is this enhancement important?

For food list page

@kotaaaa kotaaaa added the enhancement New feature or request label Dec 3, 2023
@kotaaaa kotaaaa changed the title GET /users/:userId/containers?{containerId}={no}&{category}={no}&{groupId}={no} GET /users/:userId/containers?[containerId={no}&categoryId={no}&groupId={no}] Dec 3, 2023
@hitohata
Copy link
Member

hitohata commented Dec 3, 2023

@kotaaaa
What is the expected return value?

I think the category should be filtered in the front. So, I would like to eliminate it from this API.

@github-project-automation github-project-automation bot moved this to 🆕 New in Nishiki Dec 6, 2023
@hitohata hitohata moved this from 🆕 New to Icebox in Nishiki Dec 6, 2023
@kotaaaa kotaaaa changed the title GET /users/:userId/containers?[containerId={no}&categoryId={no}&groupId={no}] GET /containers?[containerId={no}&categoryId={no}&groupId={no}] Dec 6, 2023
@kotaaaa
Copy link
Member Author

kotaaaa commented Dec 6, 2023

(2023/12/05MTG)
GET /users/:userId/containers?[containerId={no}&categoryId={no}&groupId={no}]
->
GET /containers?[containerId={no}&categoryId={no}&groupId={no}]

@kotaaaa
Copy link
Member Author

kotaaaa commented Dec 6, 2023

(2023/12/05 MTG)
Query parameters are not must requirement for stage 1, so make it icebox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Icebox
Development

No branches or pull requests

2 participants