Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the /starky-connect #109

Open
Marchand-Nicolas opened this issue Feb 20, 2025 · 5 comments · May be fixed by #111
Open

Enhance the /starky-connect #109

Marchand-Nicolas opened this issue Feb 20, 2025 · 5 comments · May be fixed by #111
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers OD Build Issue reserved for the OD Build open for contribution An issue that is available for an Only Dust contribution

Comments

@Marchand-Nicolas
Copy link
Collaborator

Description 📹

Enhance the /starky-connect command by displaying a "Reconnect {networkName}" button for each network when the user has already linked a Starknet wallet on all networks. Also, fix the logic of alreadyConnectedOnBothNetworks to support multiple networks from configs/networks.json.

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Update the alreadyConnectedOnBothNetworks logic:

    • Modify the logic to check across multiple networks instead of assuming only two.
    • Ensure that it dynamically checks the number of configured networks in configs/networks.json rather than a hardcoded value.
  3. Modify the response when a user is already connected on all networks:

    • Instead of just displaying the message:
      "You have already linked a Starknet wallet to this Discord server on both networks. Use /starky-disconnect first if you want to link a new one",
      dynamically generate a message that accounts for all available networks.
    • Add "Reconnect {networkName}" buttons for each network.
  4. Implement UI components for the buttons:

    • Utilize ActionRowBuilder and ButtonBuilder to create buttons dynamically for each network.
    • Each button should allow users to reconnect to the specific network.
  5. Ensure proper error handling and logging:

    • Update logging to provide better insights in case of unexpected behavior.
    • Handle edge cases where network configurations might change.
  6. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:

    git commit -m "Fix: Display reconnect buttons and update multi-network support"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@Marchand-Nicolas Marchand-Nicolas added enhancement New feature or request good first issue Good for newcomers OD Build Issue reserved for the OD Build open for contribution An issue that is available for an Only Dust contribution labels Feb 20, 2025
@OWK50GA
Copy link
Contributor

OWK50GA commented Feb 20, 2025

Hi, @Marchand-Nicolas
I'm a Frontend Web Developer and I'd like to take this issue.

ETA - 12 hours

@Abeeujah
Copy link
Contributor

Hi @Marchand-Nicolas The issue is descriptive enough, and the expected steps to resolution is clear enough, Can I work on this?

ETA - 8 HRs

@hoangkianh
Copy link
Contributor

I'd love to give this a go.

@od-hunter
Copy link

Hi @Marchand-Nicolas , can I work on this real quick?

@Elite-tch
Copy link
Contributor

hey @Marchand-Nicolas may i be assign this issue
ETA 12hrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers OD Build Issue reserved for the OD Build open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants