Allow only one message recipient and add possibility to configure mor…

…e than one recipient (#1033) * feat: added MaxNumberOfMessageRecipients * fix: integration-test appsettings * fix: updated Validator * chore: removed custom validation name --------- Co-authored-by: Eric Brunner <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nmshd · Jan 27, 2025 · 0421851 · 0421851
1 parent 6d4a4da
commit 0421851
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 8 deletions.
diff --git a/.ci/appsettings.override.postgres.docker.json b/.ci/appsettings.override.postgres.docker.json
@@ -79,7 +79,8 @@
         },
         "Messages": {
             "Application": {
-                "DidDomainName": "localhost"
+                "DidDomainName": "localhost",
+                "MaxNumberOfMessageRecipients": 5
             },
             "Infrastructure": {
                 "SqlDatabase": {

diff --git a/.ci/appsettings.override.postgres.local.json b/.ci/appsettings.override.postgres.local.json
@@ -79,7 +79,8 @@
         },
         "Messages": {
             "Application": {
-                "DidDomainName": "localhost"
+                "DidDomainName": "localhost",
+                "MaxNumberOfMessageRecipients": 5
             },
             "Infrastructure": {
                 "SqlDatabase": {

diff --git a/.ci/appsettings.override.sqlserver.docker.json b/.ci/appsettings.override.sqlserver.docker.json
@@ -79,7 +79,8 @@
         },
         "Messages": {
             "Application": {
-                "DidDomainName": "localhost"
+                "DidDomainName": "localhost",
+                "MaxNumberOfMessageRecipients": 5
             },
             "Infrastructure": {
                 "SqlDatabase": {

diff --git a/.ci/appsettings.override.sqlserver.local.json b/.ci/appsettings.override.sqlserver.local.json
@@ -79,7 +79,8 @@
         },
         "Messages": {
             "Application": {
-                "DidDomainName": "localhost"
+                "DidDomainName": "localhost",
+                "MaxNumberOfMessageRecipients": 5
             },
             "Infrastructure": {
                 "SqlDatabase": {

diff --git a/Applications/ConsumerApi/src/appsettings.json b/Applications/ConsumerApi/src/appsettings.json
@@ -84,7 +84,8 @@
                 "Pagination": {
                     "DefaultPageSize": 50,
                     "MaxPageSize": 200
-                }
+                },
+                "MaxNumberOfMessageRecipients": 1
             },
             "Infrastructure": {
                 "SqlDatabase": {

diff --git a/...ations/ConsumerApi/test/ConsumerApi.Tests.Integration/api.appsettings.local.override.json b/...ations/ConsumerApi/test/ConsumerApi.Tests.Integration/api.appsettings.local.override.json
@@ -50,7 +50,8 @@
         },
         "Messages": {
             "Application": {
-                "DidDomainName": "localhost"
+                "DidDomainName": "localhost",
+                "MaxNumberOfMessageRecipients": 5
             },
             "Infrastructure": {
                 "SqlDatabase": {

diff --git a/Modules/Messages/src/Messages.Application/ApplicationOptions.cs b/Modules/Messages/src/Messages.Application/ApplicationOptions.cs
@@ -14,6 +14,9 @@ public class ApplicationOptions
     [MinLength(3)]
     [MaxLength(45)]
     public string DidDomainName { get; set; } = null!;
+
+    [Required]
+    public int MaxNumberOfMessageRecipients { get; set; }
 }
 
 public class PaginationOptions

diff --git a/Modules/Messages/src/Messages.Application/Messages/Commands/SendMessage/Validator.cs b/Modules/Messages/src/Messages.Application/Messages/Commands/SendMessage/Validator.cs
@@ -5,12 +5,13 @@
 using Backbone.Modules.Messages.Domain.Ids;
 using Backbone.Tooling.Extensions;
 using FluentValidation;
+using Microsoft.Extensions.Options;
 
 namespace Backbone.Modules.Messages.Application.Messages.Commands.SendMessage;
 
 public class Validator : AbstractValidator<SendMessageCommand>
 {
-    public Validator()
+    public Validator(IOptions<ApplicationOptions> options)
     {
         RuleFor(m => m.Recipients)
             .DetailedNotNull()
@@ -21,7 +22,8 @@ public Validator()
                 .SetValidator(new SendMessageCommandRecipientInformationValidator()));
 
         RuleFor(m => m.Recipients.Count)
-            .InclusiveBetween(1, 50).WithErrorCode(GenericApplicationErrors.Validation.InvalidPropertyValue().Code);
+            .LessThanOrEqualTo(options.Value.MaxNumberOfMessageRecipients)
+            .WithErrorCode(GenericApplicationErrors.Validation.InvalidPropertyValue().Code);
 
         RuleFor(m => m.Body).DetailedNotNull().NumberOfBytes(1, 10.Mebibytes());