chore: Address comments

Author: MH321Productions

Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Contexts/TagsContext.cs

@@ -10,6 +10,8 @@ User requests available Tags
         And the response attributes contain tags
 
     Scenario: Requesting the tags with the current hash
-        Given the most current hash h
-        When A GET request to the /Tags endpoint gets sent with hash h
+        Given a list of tags l with an ETag e
+        And I didn't change since the last fetch
+        When A GET request to the /Tags endpoint gets sent with the If-None-Match header set to e
         Then the response status code is 304 (Not modified)
+        And the response content is empty

Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Tags/GET.feature

@@ -11,27 +11,28 @@ public class TagsStepDefinitions
 {
     private readonly ResponseContext _responseContext;
     private readonly ClientPool _clientPool;
-    private readonly TagsContext _tagsContext;
 
     private CachedApiResponse<ListTagsResponse>? _listTagsResponse;
 
     public TagsStepDefinitions(ResponseContext responseContext, ClientPool clientPool)
     {
         _responseContext = responseContext;
         _clientPool = clientPool;
-        _tagsContext = new TagsContext();
     }
 
     #region Given
 
-    [Given($@"the most current hash {RegexFor.SINGLE_THING}")]
-    public async Task GivenTheMostCurrentHash(string hash)
+    [Given($@"a list of tags {RegexFor.SINGLE_THING} with an ETag {RegexFor.SINGLE_THING}")]
+    public async Task GivenAListOfTagsWithETag(string list, string hash)
     {
         await WhenAGETRequestToTheTagsEndpointGetsSent();
 
         _listTagsResponse!.Should().BeASuccess();
+    }
 
-        _tagsContext.TagHashes[hash] = _listTagsResponse!.ETag;
+    [Given("I didn't change since the last fetch")]
+    public void GivenIDidntChangeSinceLastFetch()
+    {
     }
 
     #endregion
@@ -46,11 +47,11 @@ public async Task WhenAGETRequestToTheTagsEndpointGetsSent()
         _responseContext.WhenResponse = _listTagsResponse = await client.Tags.ListTags();
     }
 
-    [When($@"A GET request to the /Tags endpoint gets sent with hash {RegexFor.SINGLE_THING}")]
+    [When($@"A GET request to the /Tags endpoint gets sent with the If-None-Match header set to {RegexFor.SINGLE_THING}")]
     public async Task WhenAGETRequestToTheTagsEndpointGetsSentWithHash(string hash)
     {
         var client = _clientPool.Anonymous;
-        _responseContext.WhenResponse = _listTagsResponse = await client.Tags.ListTags(new CacheControl { ETag = _tagsContext.TagHashes[hash] });
+        _responseContext.WhenResponse = _listTagsResponse = await client.Tags.ListTags(new CacheControl { ETag = _listTagsResponse!.ETag });
     }
 
     #endregion
@@ -72,5 +73,12 @@ public void AndTheResponseAttributesContainTags()
         }
     }
 
+    [Then("the response content is empty")]
+    public void ThenTheResponseContentIsEmpty()
+    {
+        _listTagsResponse!.NotModified.Should().BeTrue();
+        _listTagsResponse!.Result.Should().BeNull();
+    }
+
     #endregion
 }

Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/StepDefinitions/TagsStepDefinitions.cs

@@ -8,6 +8,6 @@ public class TagsEndpoint(EndpointClient client) : ConsumerApiEndpoint(client)
 {
     public async Task<CachedApiResponse<ListTagsResponse>> ListTags(CacheControl? cacheControl = null)
     {
-        return await _client.GetCachedUnauthenticated<ListTagsResponse>($"api/{API_VERSION}/Tags", null, null, cacheControl);
+        return await _client.GetCachedUnauthenticated<ListTagsResponse>($"api/{API_VERSION}/Tags", cacheControl: cacheControl);
     }
 }