Skip to content

Commit 72cc30c

Browse files
committed
test: add tests for MessageKey to other deletion process related tests
1 parent 4dec87b commit 72cc30c

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

Modules/Devices/test/Devices.Domain.Tests/Identities/CancelDeletionProcessTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ private static void AssertAuditLogEntryWasCreated(IdentityDeletionProcess deleti
9292
deletionProcess.AuditLog.ShouldHaveCount(2);
9393

9494
var auditLogEntry = deletionProcess.AuditLog[1];
95+
auditLogEntry.MessageKey.ShouldBe(MessageKey.CancelledByOwner);
9596
auditLogEntry.OldStatus.ShouldBe(DeletionProcessStatus.Active);
9697
auditLogEntry.NewStatus.ShouldBe(DeletionProcessStatus.Cancelled);
9798
}

Modules/Devices/test/Devices.Domain.Tests/Identities/DeletionProcessGracePeriodTests.cs renamed to Modules/Devices/test/Devices.Domain.Tests/Identities/DeletionGracePeriodReminderSentTests.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Backbone.BuildingBlocks.Domain.Exceptions;
1+
using Backbone.BuildingBlocks.Domain.Exceptions;
22
using Backbone.Modules.Devices.Domain.Entities.Identities;
33
using Backbone.Modules.Devices.Domain.Tests.Identities.TestDoubles;
44
using Backbone.Tooling;
@@ -21,7 +21,7 @@ public void DeletionGracePeriodReminder1Sent_updates_GracePeriodReminder1SentAt(
2121

2222
// Assert
2323
var deletionProcess = identity.DeletionProcesses.FirstOrDefault(d => d.Status == DeletionProcessStatus.Active)!;
24-
AssertAuditLogEntryWasCreated(deletionProcess);
24+
AssertAuditLogEntryWasCreated(deletionProcess, MessageKey.GracePeriodReminder1Sent);
2525
deletionProcess.GracePeriodReminder1SentAt.ShouldBe(currentDateTime);
2626
}
2727

@@ -52,7 +52,7 @@ public void DeletionGracePeriodReminder2Sent_updates_GracePeriodReminder2SentAt(
5252

5353
// Assert
5454
var deletionProcess = identity.DeletionProcesses.FirstOrDefault(d => d.Status == DeletionProcessStatus.Active)!;
55-
AssertAuditLogEntryWasCreated(deletionProcess);
55+
AssertAuditLogEntryWasCreated(deletionProcess, MessageKey.GracePeriodReminder2Sent);
5656
deletionProcess.GracePeriodReminder2SentAt.ShouldBe(currentDateTime);
5757
}
5858

@@ -84,7 +84,7 @@ public void DeletionGracePeriodReminder3Sent_updates_GracePeriodReminder3SentAt(
8484

8585
// Assert
8686
var deletionProcess = identity.DeletionProcesses.FirstOrDefault(d => d.Status == DeletionProcessStatus.Active)!;
87-
AssertAuditLogEntryWasCreated(deletionProcess);
87+
AssertAuditLogEntryWasCreated(deletionProcess, MessageKey.GracePeriodReminder3Sent);
8888
deletionProcess.GracePeriodReminder3SentAt.ShouldBe(currentDateTime);
8989
}
9090

@@ -103,12 +103,13 @@ public void DeletionGracePeriodReminder3Sent_fails_when_no_active_deletion_proce
103103
acting.ShouldThrow<DomainException>().ShouldHaveError("error.platform.validation.device.deletionProcessIsNotInRequiredStatus");
104104
}
105105

106-
private static void AssertAuditLogEntryWasCreated(IdentityDeletionProcess deletionProcess)
106+
private static void AssertAuditLogEntryWasCreated(IdentityDeletionProcess deletionProcess, MessageKey expectedMessageKey)
107107
{
108108
deletionProcess.AuditLog.ShouldHaveCount(2);
109109

110110
var auditLogEntry = deletionProcess.AuditLog[1];
111111
auditLogEntry.CreatedAt.ShouldBe(SystemTime.UtcNow);
112+
auditLogEntry.MessageKey.ShouldBe(expectedMessageKey);
112113
auditLogEntry.IdentityAddressHash.ShouldBeEquivalentTo(new byte[] { 1, 2, 3 });
113114
auditLogEntry.OldStatus.ShouldBe(DeletionProcessStatus.Active);
114115
auditLogEntry.NewStatus.ShouldBe(DeletionProcessStatus.Active);

Modules/Devices/test/Devices.Domain.Tests/Identities/StartDeletionProcessTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ private static void AssertDeletionProcessWasStarted(Identity activeIdentity)
130130
private static void AssertAuditLogEntryWasCreated(IdentityDeletionProcess deletionProcess)
131131
{
132132
var auditLogEntry = deletionProcess.AuditLog[0];
133+
auditLogEntry.MessageKey.ShouldBe(MessageKey.StartedByOwner);
133134
auditLogEntry.CreatedAt.ShouldBe(SystemTime.UtcNow);
134135
auditLogEntry.IdentityAddressHash.ShouldBeEquivalentTo(new byte[] { 1, 2, 3 });
135136
auditLogEntry.OldStatus.ShouldBeNull();

0 commit comments

Comments
 (0)