feat: remove unused BlobReference column from DatawalletModification

Author: tnotheis

Modules/Synchronization/src/Synchronization.Application/Datawallets/Commands/PushDatawalletModifications/Handler.cs

@@ -77,7 +77,7 @@ private async Task CreateModifications()
     {
         var blobName = Guid.NewGuid().ToString("N");
 
-        var newModifications = _request.Modifications.Select(m => CreateModification(m, blobName));
+        var newModifications = _request.Modifications.Select(CreateModification);
 
         _dbContext.Set<Datawallet>().Update(_datawallet!);
 
@@ -88,7 +88,7 @@ private async Task CreateModifications()
         _modifications = modificationsArray;
     }
 
-    private DatawalletModification CreateModification(PushDatawalletModificationItem modificationDto, string blobReference)
+    private DatawalletModification CreateModification(PushDatawalletModificationItem modificationDto)
     {
         return _datawallet!.AddModification(
             MapDatawalletModificationType(modificationDto.Type),
@@ -97,8 +97,7 @@ private DatawalletModification CreateModification(PushDatawalletModificationItem
             modificationDto.ObjectIdentifier,
             modificationDto.PayloadCategory,
             modificationDto.EncryptedPayload,
-            _activeDevice,
-            blobReference
+            _activeDevice
         );
     }
 

Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/FinalizeSyncRun/Handler.cs

@@ -116,8 +116,6 @@ private List<DatawalletModification> AddModificationsToDatawallet(List<PushDataw
         if (modifications.Count == 0)
             return [];
 
-        var blobName = Guid.NewGuid().ToString("N");
-
         var newModifications = new List<DatawalletModification>();
 
         foreach (var modificationDto in modifications)
@@ -129,8 +127,7 @@ private List<DatawalletModification> AddModificationsToDatawallet(List<PushDataw
                 modificationDto.ObjectIdentifier,
                 modificationDto.PayloadCategory,
                 modificationDto.EncryptedPayload,
-                _activeDevice,
-                blobName);
+                _activeDevice);
 
             newModifications.Add(newModification);
         }

Modules/Synchronization/src/Synchronization.Domain/Entities/Datawallet.cs

@@ -39,15 +39,15 @@ public void Upgrade(DatawalletVersion targetVersion)
     }
 
     public DatawalletModification AddModification(DatawalletModificationType type, DatawalletVersion datawalletVersionOfModification, string collection, string objectIdentifier,
-        string? payloadCategory, byte[]? encryptedPayload, DeviceId createdByDevice, string blobReference)
+        string? payloadCategory, byte[]? encryptedPayload, DeviceId createdByDevice)
     {
         if (datawalletVersionOfModification > Version)
             throw new DomainException(DomainErrors.Datawallet.DatawalletVersionOfModificationTooHigh(Version, datawalletVersionOfModification));
 
         var indexOfNewModification = Modifications.Count > 0 ? Modifications.Max(m => m.Index) + 1 : 0;
 
         var newModification = new DatawalletModification(this, datawalletVersionOfModification, indexOfNewModification, type, collection, objectIdentifier, payloadCategory, encryptedPayload,
-            createdByDevice, blobReference);
+            createdByDevice);
         Modifications.Add(newModification);
 
         if (DomainEvents.All(d => d.GetType() != typeof(DatawalletModifiedDomainEvent)))

Modules/Synchronization/src/Synchronization.Domain/Entities/DatawalletModification.cs

@@ -17,11 +17,10 @@ private DatawalletModification()
         CreatedBy = null!;
         CreatedByDevice = null!;
         Collection = null!;
-        BlobReference = null!;
     }
 
     public DatawalletModification(Datawallet datawallet, DatawalletVersion datawalletVersion, long index, DatawalletModificationType type, string collection, string objectIdentifier,
-        string? payloadCategory, byte[]? encryptedPayload, DeviceId createdByDevice, string blobReference)
+        string? payloadCategory, byte[]? encryptedPayload, DeviceId createdByDevice)
     {
         Id = DatawalletModificationId.New();
         Datawallet = datawallet;
@@ -37,7 +36,6 @@ public DatawalletModification(Datawallet datawallet, DatawalletVersion datawalle
 
         CreatedAt = SystemTime.UtcNow;
         CreatedByDevice = createdByDevice;
-        BlobReference = blobReference;
     }
 
     public DatawalletModificationId Id { get; }
@@ -52,15 +50,6 @@ public DatawalletModification(Datawallet datawallet, DatawalletVersion datawalle
     public string Collection { get; }
     public DatawalletModificationType Type { get; }
     public byte[]? EncryptedPayload { get; private set; }
-    public string BlobReference { get; }
-
-    public void LoadEncryptedPayload(byte[] encryptedPayload)
-    {
-        if (EncryptedPayload != null)
-            throw new Exception("Cannot change the encrypted payload of a datawallet modification.");
-
-        EncryptedPayload = encryptedPayload;
-    }
 }
 
 public enum DatawalletModificationType