From 1d415bf7aaa9f29e38b6a0dde7b6e533a71dce63 Mon Sep 17 00:00:00 2001 From: Nikola Dmitrasinovic Date: Wed, 31 Jan 2024 08:49:13 +0100 Subject: [PATCH 1/4] fix: change exception reason to UniqueKeyViolation instead of DuplicateIndex --- .../SyncRuns/Commands/StartSyncRun/Handler.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs b/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs index 956d8414e5..9363a3da41 100644 --- a/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs +++ b/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs @@ -133,7 +133,7 @@ private async Task CreateNewSyncRun(IEnumerable events) } catch (DbUpdateException ex) { - if (ex.HasReason(DbUpdateExceptionReason.DuplicateIndex)) + if (ex.HasReason(DbUpdateExceptionReason.UniqueKeyViolation)) throw new OperationFailedException(ApplicationErrors.SyncRuns.CannotStartSyncRunWhenAnotherSyncRunIsRunning()); throw; From 51cd8166fd8ae58fe5c7c2708191aa4491ee9cbd Mon Sep 17 00:00:00 2001 From: Nikola Dmitrasinovic Date: Wed, 31 Jan 2024 08:58:44 +0100 Subject: [PATCH 2/4] fix: return DuplicateIndex and UniqueKeyViolation exception reason --- .../SyncRuns/Commands/StartSyncRun/Handler.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs b/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs index 9363a3da41..4f7b1923b3 100644 --- a/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs +++ b/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs @@ -133,6 +133,9 @@ private async Task CreateNewSyncRun(IEnumerable events) } catch (DbUpdateException ex) { + if (ex.HasReason(DbUpdateExceptionReason.DuplicateIndex)) + throw new OperationFailedException(ApplicationErrors.SyncRuns.CannotStartSyncRunWhenAnotherSyncRunIsRunning()); + if (ex.HasReason(DbUpdateExceptionReason.UniqueKeyViolation)) throw new OperationFailedException(ApplicationErrors.SyncRuns.CannotStartSyncRunWhenAnotherSyncRunIsRunning()); From 14b589a95ccea34b69a52185576abfe91a13cdd7 Mon Sep 17 00:00:00 2001 From: Nikola Dmitrasinovic Date: Wed, 31 Jan 2024 09:26:16 +0100 Subject: [PATCH 3/4] refactor: merge IF cases --- .../SyncRuns/Commands/StartSyncRun/Handler.cs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs b/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs index 4f7b1923b3..435ccc95db 100644 --- a/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs +++ b/Modules/Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs @@ -133,10 +133,7 @@ private async Task CreateNewSyncRun(IEnumerable events) } catch (DbUpdateException ex) { - if (ex.HasReason(DbUpdateExceptionReason.DuplicateIndex)) - throw new OperationFailedException(ApplicationErrors.SyncRuns.CannotStartSyncRunWhenAnotherSyncRunIsRunning()); - - if (ex.HasReason(DbUpdateExceptionReason.UniqueKeyViolation)) + if (ex.HasReason(DbUpdateExceptionReason.DuplicateIndex) || ex.HasReason(DbUpdateExceptionReason.UniqueKeyViolation)) throw new OperationFailedException(ApplicationErrors.SyncRuns.CannotStartSyncRunWhenAnotherSyncRunIsRunning()); throw; From 9a9080fcbf25d232f121a4b56c253107a2f446f0 Mon Sep 17 00:00:00 2001 From: Nikola Dmitrasinovic Date: Tue, 6 Feb 2024 10:58:15 +0100 Subject: [PATCH 4/4] ci: trigger pipelines