Support Relationship Decomposition Based Identity Deletion (#330)

* chore: update transport types * chore: update runtime types
nmshd · Nov 15, 2024 · 04cc4a0 · 04cc4a0
1 parent 0465930
commit 04cc4a0
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/packages/runtime/src/types/transport/RelationshipDTO.ts b/packages/runtime/src/types/transport/RelationshipDTO.ts
@@ -21,13 +21,14 @@ export enum RelationshipAuditLogEntryReason {
     AcceptanceOfReactivation = "AcceptanceOfReactivation",
     RejectionOfReactivation = "RejectionOfReactivation",
     RevocationOfReactivation = "RevocationOfReactivation",
-    Decomposition = "Decomposition"
+    Decomposition = "Decomposition",
+    DecompositionDueToIdentityDeletion = "DecompositionDueToIdentityDeletion"
 }
 
 export interface RelationshipAuditLogEntryDTO {
     createdAt: string;
     createdBy: string;
-    createdByDevice: string;
+    createdByDevice?: string;
     reason: RelationshipAuditLogEntryReason;
     oldStatus?: RelationshipStatus;
     newStatus: RelationshipStatus;

diff --git a/packages/runtime/src/useCases/transport/relationships/RelationshipMapper.ts b/packages/runtime/src/useCases/transport/relationships/RelationshipMapper.ts
@@ -30,7 +30,7 @@ export class RelationshipMapper {
         return {
             createdAt: entry.createdAt.toString(),
             createdBy: entry.createdBy.toString(),
-            createdByDevice: entry.createdByDevice.toString(),
+            createdByDevice: entry.createdByDevice?.toString(),
             reason: entry.reason,
             oldStatus: entry.oldStatus,
             newStatus: entry.newStatus

diff --git a/packages/transport/src/modules/relationships/local/RelationshipAuditLog.ts b/packages/transport/src/modules/relationships/local/RelationshipAuditLog.ts
@@ -9,7 +9,7 @@ export class RelationshipAuditLog {
             return RelationshipAuditLogEntry.from({
                 createdAt: CoreDate.from(entry.createdAt),
                 createdBy: CoreAddress.from(entry.createdBy),
-                createdByDevice: CoreId.from(entry.createdByDevice),
+                createdByDevice: entry.createdByDevice ? CoreId.from(entry.createdByDevice) : undefined,
                 reason: entry.reason,
                 oldStatus: entry.oldStatus,
                 newStatus: entry.newStatus

diff --git a/packages/transport/src/modules/relationships/local/RelationshipAuditLogEntry.ts b/packages/transport/src/modules/relationships/local/RelationshipAuditLogEntry.ts
@@ -6,7 +6,7 @@ import { RelationshipStatus } from "../transmission/RelationshipStatus";
 export interface IRelationshipAuditLogEntry extends ISerializable {
     createdAt: ICoreDate;
     createdBy: ICoreAddress;
-    createdByDevice: ICoreId;
+    createdByDevice?: ICoreId;
     reason: RelationshipAuditLogEntryReason;
     oldStatus?: RelationshipStatus;
     newStatus: RelationshipStatus;
@@ -22,9 +22,9 @@ export class RelationshipAuditLogEntry extends Serializable implements IRelation
     @serialize()
     public createdBy: CoreAddress;
 
-    @validate()
+    @validate({ nullable: true })
     @serialize()
-    public createdByDevice: CoreId;
+    public createdByDevice?: CoreId;
 
     @validate({
         customValidator: (v) => (!Object.values(RelationshipAuditLogEntryReason).includes(v) ? `must be one of: ${Object.values(RelationshipAuditLogEntryReason)}` : undefined)

diff --git a/packages/transport/src/modules/relationships/transmission/RelationshipAuditLog.ts b/packages/transport/src/modules/relationships/transmission/RelationshipAuditLog.ts
@@ -5,7 +5,7 @@ export interface BackboneRelationshipAuditLog extends Array<BackboneRelationship
 export interface BackboneRelationshipAuditLogEntry {
     createdAt: string;
     createdBy: string;
-    createdByDevice: string;
+    createdByDevice?: string;
     reason: RelationshipAuditLogEntryReason;
     oldStatus?: RelationshipStatus;
     newStatus: RelationshipStatus;
@@ -21,5 +21,6 @@ export enum RelationshipAuditLogEntryReason {
     AcceptanceOfReactivation = "AcceptanceOfReactivation",
     RejectionOfReactivation = "RejectionOfReactivation",
     RevocationOfReactivation = "RevocationOfReactivation",
-    Decomposition = "Decomposition"
+    Decomposition = "Decomposition",
+    DecompositionDueToIdentityDeletion = "DecompositionDueToIdentityDeletion"
 }