From 64d1a3874ff87a38d22869c2443a4024d9f7a400 Mon Sep 17 00:00:00 2001
From: Milena Czierlinski <milena.czierlinski@js-soft.com>
Date: Mon, 21 Oct 2024 15:45:58 +0200
Subject: [PATCH] feat: clean up PR

---
 .../src/modules/attributes/AttributesController.ts            | 4 +---
 .../src/modules/attributes/local/AttributeSuccessorParams.ts  | 4 ----
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/packages/consumption/src/modules/attributes/AttributesController.ts b/packages/consumption/src/modules/attributes/AttributesController.ts
index a3776bd9b..356f24d48 100644
--- a/packages/consumption/src/modules/attributes/AttributesController.ts
+++ b/packages/consumption/src/modules/attributes/AttributesController.ts
@@ -554,7 +554,6 @@ export class AttributesController extends ConsumptionBaseController {
             content: parsedSuccessorParams.content,
             succeeds: predecessorId,
             shareInfo: parsedSuccessorParams.shareInfo,
-            // TODO: remove parentId or add isDefault (maybe also in other places)
             parentId: parsedSuccessorParams.parentId,
             createdAt: parsedSuccessorParams.createdAt,
             succeededBy: parsedSuccessorParams.succeededBy
@@ -910,8 +909,7 @@ export class AttributesController extends ConsumptionBaseController {
             succeeds: parsedSuccessorParams.succeeds,
             succeededBy: parsedSuccessorParams.succeededBy,
             shareInfo: parsedSuccessorParams.shareInfo,
-            parentId: parsedSuccessorParams.parentId,
-            isDefault: parsedSuccessorParams.isDefault
+            parentId: parsedSuccessorParams.parentId
         });
 
         if (!predecessor.isThirdPartyRelationshipAttribute()) {
diff --git a/packages/consumption/src/modules/attributes/local/AttributeSuccessorParams.ts b/packages/consumption/src/modules/attributes/local/AttributeSuccessorParams.ts
index da406292b..2b327fd5f 100644
--- a/packages/consumption/src/modules/attributes/local/AttributeSuccessorParams.ts
+++ b/packages/consumption/src/modules/attributes/local/AttributeSuccessorParams.ts
@@ -44,10 +44,6 @@ export class AttributeSuccessorParams extends Serializable implements IAttribute
     @serialize()
     public parentId?: CoreId;
 
-    @validate({ nullable: true })
-    @serialize()
-    public isDefault?: true;
-
     public static from(value: IAttributeSuccessorParams | AttributeSuccessorParamsJSON): AttributeSuccessorParams {
         return this.fromAny(value);
     }