Allow uploading empty files (#374)

* fix: allow uploading empty files * test: update tests
nmshd · Dec 19, 2024 · 8d2dc74 · 8d2dc74
1 parent 919eefc
commit 8d2dc74
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/packages/runtime/src/useCases/transport/files/UploadOwnFile.ts b/packages/runtime/src/useCases/transport/files/UploadOwnFile.ts
@@ -44,15 +44,6 @@ class Validator extends SchemaValidator<UploadOwnFileValidatableRequest> {
             );
         }
 
-        if (input.content.length === 0) {
-            validationResult.addFailure(
-                new ValidationFailure(
-                    RuntimeErrors.general.invalidPropertyValue(`'${nameof<UploadOwnFileValidatableRequest>((r) => r.content)}' is empty`),
-                    nameof<UploadOwnFileValidatableRequest>((r) => r.content)
-                )
-            );
-        }
-
         if (input.expiresAt && CoreDate.from(input.expiresAt).isSameOrBefore(CoreDate.utc())) {
             validationResult.addFailure(
                 new ValidationFailure(

diff --git a/packages/runtime/test/transport/files.test.ts b/packages/runtime/test/transport/files.test.ts
@@ -67,13 +67,19 @@ describe("File upload", () => {
         expect(file).toBeDefined();
 
         const response = await transportServices1.files.downloadFile({ id: file.id });
-        expect(response.isSuccess).toBeTruthy();
+        expect(response).toBeSuccessful();
+
         expect(response.value.content.byteLength).toBe(4);
     });
 
-    test("cannot upload an empty file", async () => {
+    test("can exchange an empty file", async () => {
         const response = await transportServices1.files.uploadOwnFile(await makeUploadRequest({ content: Buffer.of() }));
-        expect(response).toBeAnError("'content' is empty", "error.runtime.validation.invalidPropertyValue");
+        expect(response).toBeSuccessful();
+
+        const downloadResponse = await transportServices1.files.downloadFile({ id: response.value.id });
+        expect(downloadResponse).toBeSuccessful();
+
+        expect(downloadResponse.value.content.byteLength).toBe(0);
     });
 
     test("cannot upload a file that is null", async () => {