From c5b3499cdf5232b860f57665ac4c131b3efbe3d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julian=20K=C3=B6nig?= <33655937+jkoenig134@users.noreply.github.com> Date: Fri, 23 Aug 2024 09:34:43 +0200 Subject: [PATCH] Package versions does not land in the buildInformation (#248) * fix: use VERSION env in writeBuildInformation.sh * ci: add VERSION to build:ci --- .ci/writeBuildInformation.sh | 11 +++++------ .github/workflows/publish.yml | 1 + 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.ci/writeBuildInformation.sh b/.ci/writeBuildInformation.sh index 7c819f29e..50d1e7f69 100755 --- a/.ci/writeBuildInformation.sh +++ b/.ci/writeBuildInformation.sh @@ -6,6 +6,11 @@ if [ -z "$(which jq)" ]; then exit 1 fi +if [ -z "$VERSION" ]; then + echo "The environment variable 'VERSION' must be set." + exit 1 +fi + if [ -z "$BUILD_NUMBER" ]; then echo "The environment variable 'BUILD_NUMBER' must be set." exit 1 @@ -23,12 +28,6 @@ fi DEPENDENCIES="${DEPENDENCIES//[\/]/\\/}" # replace '/' with '\/' because it's a special char -VERSION=$(jq .version package.json -cr) -if [ -z "$VERSION" ]; then - echo "Couldn't read the version from package.json." - exit 1 -fi - DATE=$(date -u --iso-8601=seconds) TARGET_FILE="./dist/buildInformation.js" diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 1fa8f92d6..901befea3 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -28,6 +28,7 @@ jobs: env: BUILD_NUMBER: ${{ github.run_number }} COMMIT_HASH: ${{ github.sha }} + VERSION: ${{ github.ref_name }} - run: bash .ci/publishNpm.sh env: NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}