From cdf5d4600d9b2d85ee9c56b4c5a8b6f2b25997a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julian=20K=C3=B6nig?= <33655937+jkoenig134@users.noreply.github.com> Date: Wed, 2 Oct 2024 17:12:18 +0200 Subject: [PATCH] ShareAttributeRequestItemDVOs `attribute.id` is overridden with with `undefined` (#289) --- packages/runtime/src/dataViews/DataViewExpander.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/runtime/src/dataViews/DataViewExpander.ts b/packages/runtime/src/dataViews/DataViewExpander.ts index cce26372b..ded498aae 100644 --- a/packages/runtime/src/dataViews/DataViewExpander.ts +++ b/packages/runtime/src/dataViews/DataViewExpander.ts @@ -660,11 +660,13 @@ export class DataViewExpander { response: responseItemDVO } as DecidableShareAttributeRequestItemDVO; } - // We have to manually copy the attribute id here, otherwise we could not link to the local attribute - const shareAttributeResponseItem = responseItemDVO as ShareAttributeAcceptResponseItemDVO | undefined; - if (shareAttributeResponseItem) { - attributeDVO.id = shareAttributeResponseItem.attributeId; + + if (responseItemDVO?.result === ResponseItemResult.Accepted) { + // We have to manually copy the attribute id here, otherwise we could not link to the local attribute + const shareAttributeResponseItem = responseItemDVO as ShareAttributeAcceptResponseItemDVO | undefined; + if (shareAttributeResponseItem) attributeDVO.id = shareAttributeResponseItem.attributeId; } + return { ...shareAttributeRequestItem, type: "ShareAttributeRequestItemDVO",