Auto merge of rust-lang#155056 - JonathanBrouwer:revert-lint-port, r=lqd,mati865

Revert "Port lint attributes to attribute parser"

This PR reverts the following two PRs:
- rust-lang#154808
- rust-lang#152369

This was not a clean revert, I manually solved several merge conflicts.

Closes rust-lang#154878
Closes rust-lang#154800
Closes rust-lang#155008
Re-opens rust-lang#132218 (this was never closed, oops)

r? @ghost

Author: bors

Cargo.lock

@@ -4224,6 +4224,7 @@ dependencies = [
 name = "rustc_lint_defs"
 version = "0.0.0"
 dependencies = [
+ "rustc_ast",
  "rustc_data_structures",
  "rustc_error_messages",
  "rustc_hir_id",

compiler/rustc_ast_lowering/src/lib.rs

@@ -155,7 +155,7 @@ struct LoweringContext<'a, 'hir, R> {
 
 impl<'a, 'hir, R: ResolverAstLoweringExt<'hir>> LoweringContext<'a, 'hir, R> {
     fn new(tcx: TyCtxt<'hir>, resolver: &'a mut R) -> Self {
-        let registered_tools = tcx.registered_tools(());
+        let registered_tools = tcx.registered_tools(()).iter().map(|x| x.name).collect();
         Self {
             tcx,
             resolver,

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs

@@ -295,15 +295,10 @@ impl<S: Stage> AttributeParser<S> for NakedParser {
 
         let span = self.span?;
 
-        let Some(tools) = cx.tools else {
-            unreachable!("tools required while parsing attributes");
-        };
-
-        let tools = tools.iter().map(|tool| tool.name).collect::<Vec<_>>();
         // only if we found a naked attribute do we do the somewhat expensive check
         'outer: for other_attr in cx.all_attrs {
             for allowed_attr in ALLOW_LIST {
-                if other_attr.segments().next().is_some_and(|i| tools.contains(&i.name)) {
+                if other_attr.segments().next().is_some_and(|i| cx.tools.contains(&i.name)) {
                     // effectively skips the error message  being emitted below
                     // if it's a tool attribute
                     continue 'outer;