From 1bb2f8bad86bc8928ff05aab73cd1054632e32ac Mon Sep 17 00:00:00 2001 From: Eunju Yang Date: Mon, 18 Mar 2024 17:25:53 +0900 Subject: [PATCH] [coverity] fix coverity issues This commit fixes coverity issues of auto_causes_copy - 1739360 - 1740106 Self-evaluation: Build test: [X]Passed [ ]Failed [ ]Skipped Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Eunju Yang --- nntrainer/tensor/task_executor.cpp | 6 ++---- nntrainer/utils/node_exporter.cpp | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/nntrainer/tensor/task_executor.cpp b/nntrainer/tensor/task_executor.cpp index 3784fd0b2b..c58f9b0a60 100644 --- a/nntrainer/tensor/task_executor.cpp +++ b/nntrainer/tensor/task_executor.cpp @@ -29,9 +29,7 @@ namespace nntrainer { std::atomic_int32_t TaskExecutor::ids(1); TaskExecutor::TaskExecutor(const std::string &n) : - name(n), - run_thread(true), - wait_complete(false) { + name(n), run_thread(true), wait_complete(false) { task_thread = std::thread([&]() { ml_logd("Task Thread(%s): start thread", name.c_str()); while (run_thread) { @@ -44,7 +42,7 @@ TaskExecutor::TaskExecutor(const std::string &n) : lk.unlock(); const auto &id = std::get(task_info); - auto callback = std::get(task_info); + const auto &callback = std::get(task_info); auto status = worker(task_info); callback(id, status); diff --git a/nntrainer/utils/node_exporter.cpp b/nntrainer/utils/node_exporter.cpp index c4b085317f..8f37e7f2eb 100644 --- a/nntrainer/utils/node_exporter.cpp +++ b/nntrainer/utils/node_exporter.cpp @@ -57,9 +57,7 @@ Exporter::Exporter() : stored_result(nullptr), is_exported(false) { * */ Exporter::Exporter(flatbuffers::FlatBufferBuilder *fbb) : - fbb(fbb), - stored_result(nullptr), - is_exported(false) {} + fbb(fbb), stored_result(nullptr), is_exported(false) {} #endif /** @@ -265,7 +263,7 @@ void Exporter::saveTflResult( assert(strides.size() == POOLING2D_DIM); auto poolSize = std::get>(props); assert(poolSize.size() == POOLING2D_DIM); - auto padding = std::get(props).get(); + const auto &padding = std::get(props).get(); assert(padding == "same" || padding == "valid"); switch (poolingType.get()) {