New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/rocminfo uses non-standard overrides for CMAKE_BUILD_TYPE #72

Open

stellaraccident opened this issue Feb 6, 2025 · 0 comments

Contributor

stellaraccident commented Feb 6, 2025

The result is that it does a debug build, no matter what you pass to CMAKE_BUILD_TYPE.

Relevant code:

string(TOLOWER "${ROCRTST_BLD_TYPE}" tmp)
if("${tmp}" STREQUAL release)
  set(BUILD_TYPE "Release")
  set(ISDEBUG 0)
else()
  set(BUILD_TYPE "Debug")
  set(ISDEBUG 1)
endif()

and

set(CMAKE_BUILD_TYPE ${BUILD_TYPE})

Suffice to say this is a really bad idea.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment