From 011f2732e4e29f279417709128aec7654ad243f2 Mon Sep 17 00:00:00 2001
From: Stephen Baione <stbaione@amd.com>
Date: Thu, 12 Dec 2024 21:47:04 +0000
Subject: [PATCH] Remove `pip install sentencepiece`, Update `stable` and
 `nightly` installation instructs, Only set lower-bound for `gguf`

---
 docs/shortfin/llm/user/e2e_llama8b_mi300x.md | 31 +++++++-------------
 sharktank/requirements.txt                   |  2 +-
 2 files changed, 11 insertions(+), 22 deletions(-)

diff --git a/docs/shortfin/llm/user/e2e_llama8b_mi300x.md b/docs/shortfin/llm/user/e2e_llama8b_mi300x.md
index 94c076980..313a8086c 100644
--- a/docs/shortfin/llm/user/e2e_llama8b_mi300x.md
+++ b/docs/shortfin/llm/user/e2e_llama8b_mi300x.md
@@ -22,38 +22,27 @@ python -m venv --prompt shark-ai .venv
 source .venv/bin/activate
 ```
 
-### Install `shortfin`
+## Install stable shark-ai packages
 
-You can install either the `latest stable` version of shortfin by installing
-`shark-ai` or the `nightly` version directly:
-
-#### Stable
+<!-- TODO: Add `sharktank` to `shark-ai` meta package -->
 
 ```bash
-pip install shark-ai[apps]
+pip install shark-ai[apps] sharktank
 ```
 
-#### Nightly
-
-```bash
-pip install shortfin[apps] --pre -f https://github.com/nod-ai/shark-ai/releases/expanded_assets/dev-wheels
-```
+### Nightly packages
 
-<!-- TODO: Remove when sharktank added to `shark-ai[apps]` -->
-### Install `sharktank`
+To install nightly packages:
 
-Install the `nightly` version of sharktank:
+<!-- TODO: Add `sharktank` to `shark-ai` meta package -->
 
 ```bash
-pip install sharktank --pre -f https://github.com/nod-ai/shark-ai/releases/expanded_assets/dev-wheels
+pip install shark-ai[apps] sharktank \
+    --pre --find-links https://github.com/nod-ai/shark-ai/releases/expanded_assets/dev-wheels
 ```
 
-<!-- TODO: Remove once `sentencepiece` added to nightly `sharktank` -->
-### Install `sentencepiece`
-
-```bash
-pip install sentencepiece
-```
+See also the
+[instructions here](https://github.com/nod-ai/shark-ai/blob/main/docs/nightly_releases.md).
 
 ### Define a directory for export files
 
diff --git a/sharktank/requirements.txt b/sharktank/requirements.txt
index 6ec1ea1d9..90cbedded 100644
--- a/sharktank/requirements.txt
+++ b/sharktank/requirements.txt
@@ -1,7 +1,7 @@
 iree-turbine
 
 # Runtime deps.
-gguf==0.11.0
+gguf>=0.11.0
 numpy<2.0
 
 # Model deps.