Skip to content

Commit

Permalink
Remove test_punet job from ci-sharktank.yml. (#621)
Browse files Browse the repository at this point in the history
Partial revert of #613.

This job takes over an hour to run (specifically
`test_punet_eager_fp16_validation `) and is not suitable for presubmit.

This is likely also not the right file for such tests, and if it was
then the specialized tests should go under the generic `test` job, not
at the top of the file.
  • Loading branch information
ScottTodd authored Nov 27, 2024
1 parent 2ee7676 commit 5aae18d
Showing 1 changed file with 0 additions and 39 deletions.
39 changes: 0 additions & 39 deletions .github/workflows/ci-sharktank.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,45 +22,6 @@ concurrency:
cancel-in-progress: true

jobs:
test_punet:
name: "Integration Tests - punet"
runs-on: nodai-amdgpu-mi250-x86-64
env:
PIP_CACHE_DIR: "${{ github.workspace }}/.pip-cache"
steps:
- name: "Setting up Python"
id: setup_python
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: 3.11

- name: "Checkout Code"
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Cache Pip Packages
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
id: cache-pip
with:
path: ${{ env.PIP_CACHE_DIR }}
key: pip-${{ steps.setup_python.outputs.python-version }}-${{ hashFiles('*requirements*.txt','sharktank/requirements*.txt') }}

- name: Install pip deps
run: |
python -m pip install --no-compile --upgrade pip
# Note: We install in three steps in order to satisfy requirements
# from non default locations first. Installing the PyTorch CPU
# wheels saves multiple minutes and a lot of bandwidth on runner setup.
pip install --no-compile -r pytorch-cpu-requirements.txt
pip install --no-compile -r requirements.txt -r sharktank/requirements-tests.txt -e sharktank/
# Update to the latest iree packages.
pip install -f https://iree.dev/pip-release-links.html --upgrade --pre \
iree-base-compiler iree-base-runtime --src deps \
-e "git+https://github.com/iree-org/iree-turbine.git#egg=iree-turbine"
- name: Run punet tests
run: |
pytest -v sharktank/ -m model_punet
test:
name: "Unit Tests and Type Checking"
strategy:
Expand Down

0 comments on commit 5aae18d

Please sign in to comment.