[shortfin] Refactor to avoid changing directories (#234)

Instead of changing into the directories, the working directories are
now set in the jobs.

Author: marbre

.github/workflows/ci_linux_x64-libshortfin.yml

@@ -57,8 +57,8 @@ jobs:
         ref: candidate-20240904.1006
 
     - name: Initalize IREE submodules
+      working-directory: ${{ env.IREE_REPO_DIR }}
       run : |
-        cd ${{ env.IREE_REPO_DIR }}
         git submodule update --init --depth 1 -- third_party/benchmark
         git submodule update --init --depth 1 -- third_party/cpuinfo/
         git submodule update --init --depth 1 -- third_party/flatcc
@@ -72,40 +72,44 @@ jobs:
         cache: "pip"
     - name: Install Python packages
       # TODO: Switch to `pip install -r requirements.txt -e shortfin/`.
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
-        pip install -r ${{ env.LIBSHORTFIN_DIR }}/requirements-tests.txt
-        pip install -r ${{ env.LIBSHORTFIN_DIR }}/requirements-iree-compiler.txt
+        pip install -r requirements-tests.txt
+        pip install -r requirements-iree-compiler.txt
         pip freeze
 
     - name: Build shortfin (full)
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
-        mkdir ${{ env.LIBSHORTFIN_DIR }}/build
-        cd ${{ env.LIBSHORTFIN_DIR }}/build
+        mkdir build
         cmake -GNinja \
+          -S. \
+          -Bbuild \
           -DCMAKE_C_COMPILER=clang-18 \
           -DCMAKE_CXX_COMPILER=clang++-18 \
           -DCMAKE_LINKER_TYPE=LLD \
           -DSHORTFIN_BUNDLE_DEPS=ON \
           -DSHORTFIN_IREE_SOURCE_DIR=${{ env.IREE_REPO_DIR }} \
           -DSHORTFIN_BUILD_PYTHON_BINDINGS=ON \
           ..
-        cmake --build . --target all
-        pip install -v -e .
+        cmake --build build --target all
+        pip install -v -e build/
 
     - name: Test shortfin (full)
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
-        cd ${{ env.LIBSHORTFIN_DIR }}/build
-        ctest --timeout 30 --output-on-failure
-        cd ${{ env.LIBSHORTFIN_DIR }}
+        ctest --timeout 30 --output-on-failure --test-dir build
         pytest -s
 
     - name: Build shortfin (host-only)
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
-        mkdir ${{ env.LIBSHORTFIN_DIR }}/build-host-only
-        cd ${{ env.LIBSHORTFIN_DIR }}/build-host-only
+        mkdir build-host-only
         # In this configuration, also build static+dynamic in order to verify
         # that path structurally works.
         cmake -GNinja \
+          -S. \
+          -Bbuild-host-only \
           -DCMAKE_C_COMPILER=clang-18 \
           -DCMAKE_CXX_COMPILER=clang++-18 \
           -DCMAKE_LINKER_TYPE=LLD \
@@ -115,4 +119,4 @@ jobs:
           -DSHORTFIN_BUILD_STATIC=ON \
           -DSHORTFIN_BUILD_DYNAMIC=ON \
           ..
-        cmake --build . --target all
+        cmake --build build-host-only --target all

.github/workflows/ci_linux_x64_asan-libshortfin.yml

@@ -71,8 +71,8 @@ jobs:
 
     - name: Install pyenv & Python
       if: steps.cache-python-asan.outputs.cache-hit != 'true'
+      working-directory: ${{ env.PYENV_ROOT }}
       run: |
-        cd ${{ env.PYENV_ROOT }}
         src/configure && make -C src
         export PATH=${{ env.PYENV_ROOT }}/bin:$PATH && eval "$(pyenv init -)"
         CC=clang-18 CXX=clang++-18 LDFLAGS="-lstdc++" PYTHON_CONFIGURE_OPTS="--with-address-sanitizer" pyenv install -v ${{ env.PYTHON_VER }}
@@ -109,8 +109,8 @@ jobs:
         ref: candidate-20240904.1006
 
     - name: Initalize IREE submodules
+      working-directory: ${{ env.IREE_SOURCE_DIR }}
       run : |
-        cd ${{ env.IREE_SOURCE_DIR }}
         git submodule update --init --depth 1 -- third_party/benchmark
         git submodule update --init --depth 1 -- third_party/cpuinfo/
         git submodule update --init --depth 1 -- third_party/flatcc
@@ -138,10 +138,11 @@ jobs:
 
     - name: Install Python dependencies
       if: steps.cache-python-deps-restore.outputs.cache-hit != 'true'
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
         eval "$(pyenv init -)"
-        pip install -r ${{ env.LIBSHORTFIN_DIR }}/requirements-tests.txt
-        pip install -r ${{ env.LIBSHORTFIN_DIR }}/requirements-iree-compiler.txt
+        pip install -r requirements-tests.txt
+        pip install -r requirements-iree-compiler.txt
         pip freeze
 
     - name: Save Python dependencies cache
@@ -153,9 +154,9 @@ jobs:
         key: ${{ steps.cache-python-deps-restore.outputs.cache-primary-key }}
 
     - name: Build shortfin
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
         eval "$(pyenv init -)"
-        cd ${{ env.LIBSHORTFIN_DIR }}
         SHORTFIN_IREE_SOURCE_DIR="${{ env.IREE_SOURCE_DIR }}" \
         SHORTFIN_ENABLE_ASAN=ON \
         SHORTFIN_DEV_MODE=ON \
@@ -167,7 +168,7 @@ jobs:
       env:
         # TODO(#151): Don't ignore ODR violations
         ASAN_OPTIONS: detect_odr_violation=0
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
         eval "$(pyenv init -)"
-        cd ${{ env.LIBSHORTFIN_DIR }}
         pytest -s

.github/workflows/ci_linux_x64_nogil-libshortfin.yml

@@ -56,8 +56,8 @@ jobs:
         ref: candidate-20240904.1006
 
     - name: Initalize IREE submodules
+      working-directory: ${{ env.IREE_REPO_DIR }}
       run : |
-        cd ${{ env.IREE_REPO_DIR }}
         git submodule update --init --depth 1 -- third_party/benchmark
         git submodule update --init --depth 1 -- third_party/cpuinfo/
         git submodule update --init --depth 1 -- third_party/flatcc
@@ -75,10 +75,12 @@ jobs:
         pip freeze
 
     - name: Build shortfin (full)
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
-        mkdir ${{ env.LIBSHORTFIN_DIR }}/build
-        cd ${{ env.LIBSHORTFIN_DIR }}/build
+        mkdir build
         cmake -GNinja \
+          -S. \
+          -Bbuild \
           -DCMAKE_BUILD_TYPE=Debug \
           -DCMAKE_C_COMPILER=clang-18 \
           -DCMAKE_CXX_COMPILER=clang++-18 \
@@ -87,12 +89,12 @@ jobs:
           -DSHORTFIN_IREE_SOURCE_DIR=${{ env.IREE_REPO_DIR }} \
           -DSHORTFIN_BUILD_PYTHON_BINDINGS=ON \
           ..
-        cmake --build . --target all
-        pip install -v -e .
+        cmake --build build --target all
+        pip install -v -e build/
 
     - name: Run shortfin Python tests (full)
+      working-directory: ${{ env.LIBSHORTFIN_DIR }}
       run: |
-        cd ${{ env.LIBSHORTFIN_DIR }}
         pytest -s --ignore=tests/examples/fastapi_test.py
       # TODO: Enable further tests and switch to
-      # pytest -s tests
+      # pytest -s