Skip to content

Commit fd15aa5

Browse files
Fix publish dir of llama tests, update xpass 8b test and 405b fp8 test failures (#580)
Fixes publish dir of llama tests to `out/llm/llama/benchmarks`, update xpass 8b test (`testBenchmark8B_f16_Non_Decomposed_Prefill`) and 405b fp8 test failures (`testBenchmark405B_fp8_TP8_Decomposed` and `testBenchmark405B_fp8_TP8_Non_Decomposed`). --------- Signed-off-by: aviator19941 <[email protected]> Co-authored-by: saienduri <[email protected]>
1 parent a6cb442 commit fd15aa5

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

.github/workflows/ci-llama-large-tests.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ name: Llama Benchmarking Tests
88

99
on:
1010
workflow_dispatch:
11+
pull_request:
1112
schedule:
1213
# Weekdays at 4:00 AM UTC = 9:00 PM PST.
1314
- cron: "0 4 * * 1-5"
@@ -76,14 +77,14 @@ jobs:
7677
iree-base-runtime
7778
7879
- name: Run llama tests
79-
run: pytest sharktank/tests/models/llama/benchmark_amdgpu_test.py -v -s --run-nightly-llama-tests --iree-hip-target=gfx942 --html=out/index.html
80+
run: pytest sharktank/tests/models/llama/benchmark_amdgpu_test.py -v -s --run-nightly-llama-tests --iree-hip-target=gfx942 --html=out/llm/llama/benchmark/index.html
8081

8182
- name: Deploy to GitHub Pages
8283
uses: peaceiris/actions-gh-pages@4f9cc6602d3f66b9c108549d475ec49e8ef4d45e # v4.0.0
8384
with:
8485
github_token: ${{ secrets.SHARK_PLATFORM_GH_TOKEN }}
85-
publish_dir: ./out/llm/llama/benchmarks
86-
destination_dir: ./llm/llama/benchmarks
86+
publish_dir: ./out/llm/llama/benchmark
87+
destination_dir: ./llm/llama/benchmark
8788
keep_files: true
8889

8990
- name: Upload llama executable files

sharktank/tests/models/llama/benchmark_amdgpu_test.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,6 @@ def testBenchmark8B_f16_Decomposed(self):
197197
)
198198

199199
@skipif_run_quick_llama_test
200-
@pytest.mark.xfail(reason="Compile Error", strict=True, raises=IreeCompileException)
201200
def testBenchmark8B_f16_Non_Decomposed_Prefill(self):
202201
output_file_name = self.dir_path_8b / "f16_torch_prefill"
203202
output_mlir = self.llama8b_f16_torch_sdpa_artifacts.create_file(
@@ -780,7 +779,9 @@ def testBenchmark405B_f16_TP8_Decomposed(self):
780779
cwd=self.repo_root,
781780
)
782781

783-
@pytest.mark.xfail(reason="Compile Error", strict=True, raises=IreeCompileException)
782+
@pytest.mark.xfail(
783+
reason="Benchmarking Error", strict=True, raises=IreeBenchmarkException
784+
)
784785
def testBenchmark405B_f16_TP8_Non_Decomposed(self):
785786
output_file_name = self.dir_path_405b / "f16_torch"
786787
output_mlir = self.llama405b_f16_torch_sdpa_artifacts.create_file(
@@ -828,7 +829,9 @@ def testBenchmark405B_f16_TP8_Non_Decomposed(self):
828829
cwd=self.repo_root,
829830
)
830831

831-
@pytest.mark.xfail(reason="Compile Error", strict=True, raises=IreeCompileException)
832+
@pytest.mark.xfail(
833+
reason="KeyError in theta.py", strict=True, raises=ExportMlirException
834+
)
832835
def testBenchmark405B_fp8_TP8_Decomposed(self):
833836
output_file_name = self.dir_path_405b / "fp8_decomposed"
834837
output_mlir = self.llama405b_fp8_decomposed_artifacts.create_file(
@@ -874,7 +877,9 @@ def testBenchmark405B_fp8_TP8_Decomposed(self):
874877
cwd=self.repo_root,
875878
)
876879

877-
@pytest.mark.xfail(reason="Compile Error", strict=True, raises=IreeCompileException)
880+
@pytest.mark.xfail(
881+
reason="KeyError in theta.py", strict=True, raises=ExportMlirException
882+
)
878883
def testBenchmark405B_fp8_TP8_Non_Decomposed(self):
879884
output_file_name = self.dir_path_405b / "fp8_torch"
880885
output_mlir = self.llama405b_fp8_torch_sdpa_artifacts.create_file(

0 commit comments

Comments
 (0)