From 76b6890187e2529b4e9061914468d602b087b158 Mon Sep 17 00:00:00 2001 From: Marius Brehler Date: Thu, 12 Dec 2024 17:21:01 +0100 Subject: [PATCH] [sharktank] Depend on `sentencepiece` While `gguf`'s `pyproject.toml` lists `sentencepiece` as a dependency (https://github.com/ggerganov/llama.cpp/blob/a07c32ea54850c989f0ef6989da5b955b77b7172/pyproject.toml#L20), the package does not get pulled in when installing gguf via `uv pip` or `pip`. However, without the package the sanity test `python -c "from sharktank import ops; print('Sanity check passed')"`, documented in https://github.com/nod-ai/shark-ai/blob/main/docs/nightly_releases.md#quickstart---sharktank fails. --- sharktank/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sharktank/requirements.txt b/sharktank/requirements.txt index e7181284a..d2879740c 100644 --- a/sharktank/requirements.txt +++ b/sharktank/requirements.txt @@ -5,7 +5,7 @@ gguf==0.10.0 numpy<2.0 # Needed for newer gguf versions (TODO: remove when gguf package includes this) -# sentencepiece>=0.1.98,<=0.2.0 +sentencepiece>=0.1.98,<=0.2.0 # Model deps. huggingface-hub==0.22.2