Merge pull request #51 from node-oauth/release-4.1.0

release 4.1.0 -> master

.eslintrc

@@ -0,0 +1,47 @@
+{
+  "extends": "eslint:recommended",
+  "env": {
+    "node": true,
+    "mocha": true,
+    "es6": true
+  },
+  "parserOptions": {
+    "ecmaVersion": 9,
+    "sourceType": "module",
+    "ecmaFeatures" : {
+      "globalReturn": false,
+      "impliedStrict": true,
+      "jsx": false
+    }
+  },
+  "rules": {
+    "indent": [
+      "error",
+      2
+    ],
+    "linebreak-style": [
+      "error",
+      "unix"
+    ],
+    "quotes": [
+      "error",
+      "single"
+    ],
+    "semi": [
+      "error",
+      "always"
+    ],
+    "no-console": [
+      "error"
+    ],
+    "no-unused-vars": [
+      "error", 
+      { 
+        "vars": "all",
+        "args": "none",
+        "ignoreRestSiblings": false 
+      }
+    ]
+  }
+}
+

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,65 @@
+<!-- --------------------------------------------------------------------------- 
+
+🎉 THANK YOU FOR YOUR CONTRIBUTION! 🎉
+
+We highly appreciate your time and effort to this project!
+
+
+⚠ PLEASE READ THIS FIRST ⚠
+
+1. If this is a fix for a security vulnerability you discovered please don't 
+just open this PR until we have privately discussed the vulnerability. Disclosing 
+it without contacting us can lead to severe implications for many applications 
+that run on this project.
+
+2. Make sure you have read the contribution guidelines for this project in
+order to raise the chance of getting your PR accepted. This saves you valuable 
+time and effort.
+
+3. The following structure is a basic guideline. If a section does not apply you
+can remove it.
+---------------------------------------------------------------------------- -->
+
+## Summary
+<!-- ---------------------------------------------------------------------------
+⚠ Provide one or two paragraphs
+---------------------------------------------------------------------------- -->
+
+
+
+## Linked issue(s)
+<!-- ---------------------------------------------------------------------------
+⚠ If there is no issue for this PR we won't review it
+---------------------------------------------------------------------------- -->
+
+
+
+## Involved parts of the project
+<!-- ---------------------------------------------------------------------------
+⚠ Which parts of the code is affected and which OAuth2 workflows are involved
+---------------------------------------------------------------------------- -->
+
+
+
+## Added tests?
+<!-- ---------------------------------------------------------------------------
+⚠ Did you add tests that cover your changes?
+---------------------------------------------------------------------------- -->
+
+
+
+## OAuth2 standard
+<!-- ---------------------------------------------------------------------------
+⚠ This section is important in order to review compliance with the standard(s).
+Please refer to the standard if your PR affects any functionality or is 
+otherwise related to the standard(s) in any way
+---------------------------------------------------------------------------- -->
+
+
+
+## Reproduction
+<!-- ---------------------------------------------------------------------------
+⚠ How can we reproduce your changes in an app? This is especially important
+when new features are added
+---------------------------------------------------------------------------- -->
+

.github/dependabot.yml

@@ -1,20 +1,17 @@
 version: 2
 updates:
-- package-ecosystem: npm
-  directory: "/"
-  schedule:
-    interval: daily
-  open-pull-requests-limit: 10
-  ignore:
-  - dependency-name: sinon
-    versions:
-    - 10.0.0
-    - 9.2.4
-  - dependency-name: mocha
-    versions:
-    - 8.2.1
-    - 8.3.0
-    - 8.3.1
-  - dependency-name: lodash
-    versions:
-    - 4.17.20
+  - package-ecosystem: npm
+    directory: "/"
+    schedule:
+      interval: daily
+    open-pull-requests-limit: 10
+    ignore:
+      - dependency-name: sinon
+        versions:
+          - 10.0.0
+          - 9.2.4
+      - dependency-name: mocha
+        versions:
+          - 8.2.1
+          - 8.3.0
+          - 8.3.1

.github/workflows/codeql-analysis.yml

@@ -0,0 +1,68 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL Semantic Analysis"
+
+on:
+  push: # all pushes
+  pull_request: # all PR
+  schedule:
+    - cron: '0 2 * * *' # every night at 2am
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: true
+      matrix:
+        language: [ 'javascript' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
+        # Learn more:
+        # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v1
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        # queries: ./path/to/local/query, your-org/your-repo/queries@main
+
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    # - name: Autobuild
+    #  uses: github/codeql-action/autobuild@v1
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 https://git.io/JvXDl
+
+    # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
+    #    and modify them (or add more) to build your code if your project
+    #    uses a compiled language
+
+    #- run: |
+    #   make bootstrap
+    #   make release
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v1

.github/workflows/tests.yml

@@ -0,0 +1,75 @@
+name: Test suite
+
+on:
+  push:
+    branches:
+      - master # allthough  master is push protected we still keep it
+      - development
+  pull_request: # runs on all PR
+
+jobs:
+  # ----------------------------------
+  # uncomment when a linter is added
+  # ----------------------------------
+
+  # lintjs:
+  #   name: Javascript lint
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #   - name: checkout
+  #     uses: actions/checkout@v2
+  # 
+  #   - name: setup node
+  #     uses: actions/setup-node@v1
+  #     with:
+  #       node-version: '12.x'
+  # 
+  #   - name: cache dependencies
+  #     uses: actions/cache@v1
+  #     with:
+  #       path: ~/.npm
+  #       key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+  #       restore-keys: |
+  #         ${{ runner.os }}-node-
+  #   - run: npm ci
+  #   - run: npm run lint
+
+  unittest:
+    name: unit tests
+    runs-on: ubuntu-latest
+    # uncomment when a linter is added
+    # needs: [lintjs]
+    strategy:
+      matrix:
+        node: [12, 14, 16]
+    steps:
+    - name: Checkout ${{ matrix.node }}
+      uses: actions/checkout@v2
+
+    - name: Setup node ${{ matrix.node }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node }}
+
+    - name: Cache dependencies ${{ matrix.node }}
+      uses: actions/cache@v1
+      with:
+        path: ~/.npm
+        key: ${{ runner.os }}-node-${{ matrix.node }}-${{ hashFiles('**/package-lock.json') }}
+        restore-keys: |
+          ${{ runner.os }}-node-${{ matrix.node }}
+    - run: npm ci
+    - run: npm run test:coverage
+
+    # ----------------------------------
+    # uncomment when a linter is added
+    # ----------------------------------
+
+    # - name: check coverage
+    #   uses: devmasx/[email protected]
+    #   with:
+    #     type: lcov
+    #     result_path: coverage/lcov.info
+    #     min_coverage: 90
+    #     token: ${{github.token}}
+

.gitignore

@@ -30,7 +30,12 @@ npm-debug.log*~
 auto-save-list
 tramp
 .\#*
+.vscode
 
 # Org-mode
 .org-id-locations
 *_archive
+
+# coverage
+coverage
+.nyc_output

.mocharc.yml

@@ -0,0 +1,8 @@
+recursive: true
+reporter: "spec"
+retries: 1
+slow: 20
+timeout: 2000
+ui: "bdd"
+require: test/assertions
+# for more options see here https://github.com/mochajs/mocha/blob/master/example/config/.mocharc.yml

CHANGELOG.md

@@ -1,5 +1,18 @@
 ## Changelog
 
+## 4.1.0
+### Changed 
+* Bump dev dependencies to resolve vulnerabilities
+* Replaced jshint with eslint along with should and chai
+* Use sha256 when generating tokens
+
+### Added
+* Added markdown files to discuss coding rules, commit conventions, contributing guidelines, etc.
+
+### Removed
+* Removed lodash dependency
+* Removed statuses package and use built in http.STATUS_CODES instead.
+
 ### 4.0.0
  * Bump jshint from 2.12.0 to 2.13.0
  * Bump jshint from 2.12.0 to 2.13.0