slight tidy of forecast node

does part of the work of #140

Author: Dave Conway-Jones

Diff for: forecast/forecastio.js

@@ -20,7 +20,7 @@ module.exports = function(RED) {
 
     function assignmentFunction(node, date, time, lat, lon, forecastioConfig, callback) {
         if (forecastioConfig && forecastioConfig.credentials && forecastioConfig.credentials.client_key) {
-            node.apikey = forecastioConfig.credentials.client_key;
+            node.apikey = forecastioConfig.credentials.client_key.trim();
         } else {
             return callback(RED._("forecastio.error.no-credentials"));
         }
@@ -85,7 +85,12 @@ module.exports = function(RED) {
                     if (weather === "Forbidden") {
                         return callback(RED._("forecastio.error.incorrect-apikey"));
                     } else {
-                        var jsun = JSON.parse(weather);
+                        var jsun;
+                        try {
+                            jsun = JSON.parse(weather);
+                        } catch (err) {
+                            return callback(RED._("forecastio.error.api-response", { response: weather }));
+                        }
                         msg.data = jsun;
                         msg.payload.weather = jsun.daily.data[when].icon;
                         msg.payload.detail = jsun.daily.data[when].summary;

Diff for: forecast/locales/en-US/forecastio.json

@@ -33,7 +33,8 @@
             "invalid-time": "Invalid time provided",
             "invalid-date": "Invalid date provided",
             "incorrect-apikey": "Incorrect API key provided",
-            "invalid-url": "invalid url"
+            "invalid-url": "invalid url",
+            "api-response": "Error parsing response from API: __response__"
         },
         "message": {
             "weather-forecast": "Weather Forecast Information",

Diff for: forecast/package.json

@@ -1,6 +1,6 @@
 {
     "name"          : "node-red-node-forecastio",
-    "version"       : "0.1.4",
+    "version"       : "0.1.5",
     "description"   : "A Node-RED node that gets the weather forecast from Forecast.io",
     "dependencies"  : {
     },