Skip to content

Commit 730caa3

Browse files
authored
Fix react conflicting peer dependency with react-reconciler (#365)
Reverting back to `react@^16.x.x`. `react-reconciler` should be updated separately so that it can safely be used with `[email protected]`. When installing `react-nodegui` as a dependency. It will yield a warning: ``` npm WARN ERESOLVE overriding peer dependency npm WARN While resolving: [email protected] npm WARN Found: [email protected] npm WARN node_modules/react npm WARN react@"^17.0.2" from the root project npm WARN 1 more (@nodegui/react-nodegui) npm WARN npm WARN Could not resolve dependency: npm WARN peer react@"^16.13.1" from [email protected] npm WARN node_modules/react-reconciler npm WARN react-reconciler@"^0.25.1" from @nodegui/[email protected] npm WARN node_modules/@nodegui/react-nodegui npm WARN npm WARN Conflicting peer dependency: [email protected] npm WARN node_modules/react npm WARN peer react@"^16.13.1" from [email protected] npm WARN node_modules/react-reconciler npm WARN react-reconciler@"^0.25.1" from @nodegui/[email protected] npm WARN node_modules/@nodegui/react-nodegui ```
1 parent 45ccc31 commit 730caa3

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

package.json

+6-5
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,23 @@
2020
"docs": "typedoc && node ./website/docs/scripts/fixdocs.js"
2121
},
2222
"dependencies": {
23-
"@nodegui/nodegui": "^0.36.0",
23+
"@nodegui/nodegui": "^0.40.1",
2424
"@types/react-reconciler": "^0.18.0",
2525
"phin": "3.5.1",
2626
"react-deep-force-update": "^2.1.3",
2727
"react-proxy": "^2.0.8",
2828
"react-reconciler": "^0.25.1"
2929
},
3030
"peerDependencies": {
31-
"react": "^17.0.2"
31+
"react": "^16.14.0"
3232
},
3333
"devDependencies": {
34-
"@types/node": "^16.6.1",
34+
"@types/node": "^16.11.0",
35+
"@types/react": "^16.14.0",
3536
"prettier": "^2.3.2",
36-
"react": "^16.13.1",
37+
"react": "^16.14.0",
3738
"typedoc": "^0.17.8",
3839
"typedoc-plugin-markdown": "^2.4.2",
39-
"typescript": "^4.3.5"
40+
"typescript": "^4.4.4"
4041
}
4142
}

0 commit comments

Comments
 (0)