Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 now depends on simdutf #297

Closed
targos opened this issue Jan 28, 2025 · 6 comments
Closed

V8 now depends on simdutf #297

targos opened this issue Jan 28, 2025 · 6 comments

Comments

@targos
Copy link
Member

targos commented Jan 28, 2025

See https://github.com/nodejs/node-v8/actions/runs/13004555360/job/36269067298#step:6:14229

I disabled the nightly update workflow because I don't have time to fix it in the coming days.

@anonrig Should we try to use the same code as Node.js or build a separate one pinned to the version that V8 uses? I guess this depends on the stability of simdutf's API (we don't want it to break V8 if we update the dep on our side).

@targos
Copy link
Member Author

targos commented Jan 28, 2025

V8 needed a hotfix on their side to build node: v8/node@8d26658

@anonrig
Copy link
Member

anonrig commented Jan 28, 2025

I'm not sure. The APIs are extremely stable but let's hear from @lemire before making a decision here.

@lemire
Copy link
Member

lemire commented Jan 28, 2025

@targos @anonrig I definitively recommend dropping simdutf from Node if it is present in v8. I think everyone would agree.

If this causes any problem, @anonrig and myself can help.

targos added a commit to targos/node-core-utils that referenced this issue Jan 29, 2025
@targos
Copy link
Member Author

targos commented Jan 29, 2025

nodejs/node-core-utils#903 to include it in V8 updates

@targos
Copy link
Member Author

targos commented Jan 29, 2025

Ok thanks! The changes were easier than expected. I pushed them to nodejs/node@f5dea6d and nodejs/node@3b72c69.

Note that at this point, it downgrades simdutf in Node.js from version 6.0.3 to 6.0.2.

targos added a commit to nodejs/node-core-utils that referenced this issue Jan 29, 2025
@lemire
Copy link
Member

lemire commented Jan 29, 2025

@targos That's fine. :-)

@targos targos closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants