-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8 now depends on simdutf #297
Comments
V8 needed a hotfix on their side to build node: v8/node@8d26658 |
I'm not sure. The APIs are extremely stable but let's hear from @lemire before making a decision here. |
nodejs/node-core-utils#903 to include it in V8 updates |
Ok thanks! The changes were easier than expected. I pushed them to nodejs/node@f5dea6d and nodejs/node@3b72c69. Note that at this point, it downgrades simdutf in Node.js from version 6.0.3 to 6.0.2. |
@targos That's fine. :-) |
See https://github.com/nodejs/node-v8/actions/runs/13004555360/job/36269067298#step:6:14229
I disabled the nightly update workflow because I don't have time to fix it in the coming days.
@anonrig Should we try to use the same code as Node.js or build a separate one pinned to the version that V8 uses? I guess this depends on the stability of simdutf's API (we don't want it to break V8 if we update the dep on our side).
The text was updated successfully, but these errors were encountered: