diff --git a/src/node_process.h b/src/node_process.h index 461a92161ab2e5..b88a2f99483ad2 100644 --- a/src/node_process.h +++ b/src/node_process.h @@ -37,7 +37,7 @@ inline v8::Maybe ProcessEmitWarning(Environment* env, const char* fmt, Args&&... args); -v8::Maybe ProcessEmitWarningSync(Environment* env, +v8::Maybe ProcessEmitWarningSync(Environment* env, std::string_view message); v8::Maybe ProcessEmitExperimentalWarning(Environment* env, const std::string& warning); diff --git a/src/node_process_events.cc b/src/node_process_events.cc index aadd2cf4672c71..aac8d5bcbd31ed 100644 --- a/src/node_process_events.cc +++ b/src/node_process_events.cc @@ -10,6 +10,7 @@ using v8::Function; using v8::HandleScope; using v8::Isolate; using v8::Just; +using v8::JustVoid; using v8::Local; using v8::Maybe; using v8::MaybeLocal; @@ -19,7 +20,7 @@ using v8::Object; using v8::String; using v8::Value; -Maybe ProcessEmitWarningSync(Environment* env, std::string_view message) { +Maybe ProcessEmitWarningSync(Environment* env, std::string_view message) { Isolate* isolate = env->isolate(); Local context = env->context(); Local message_string; @@ -28,7 +29,7 @@ Maybe ProcessEmitWarningSync(Environment* env, std::string_view message) { NewStringType::kNormal, static_cast(message.size())) .ToLocal(&message_string)) { - return Nothing(); + return Nothing(); } Local argv[] = {message_string}; @@ -39,9 +40,9 @@ Maybe ProcessEmitWarningSync(Environment* env, std::string_view message) { if (emit_function.As() ->Call(context, v8::Undefined(isolate), arraysize(argv), argv) .IsEmpty()) { - return Nothing(); + return Nothing(); } - return Just(true); + return JustVoid(); } MaybeLocal ProcessEmit(Environment* env,