Skip to content

Commit 1a5acd0

Browse files
authoredJan 8, 2024
v8: enable maglev on supported architectures
Enable V8's new maglev compiler by default on supported architectures. This brings modest performance improvements for short-lived workloads like CLI programs (see the linked issue) and brings Node.js's configuration slightly closer to Google Chrome's. I marked this change as semver-major because Maglev can theoretically cause performance regressions, although I haven't seen an example of that in the (somewhat limited) benchmarking I've done. **Notable Change Summary:** V8's Maglev Compiler is now enabled by default on supported architectures (https://v8.dev/blog/maglev). Maglev improves CPU performance for short-lived CLI programs by around 8%. Fixes: #50690 PR-URL: #51360 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent 09a506f commit 1a5acd0

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed
 

‎configure.py

+8-4
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
valid_mips_float_abi = ('soft', 'hard')
5757
valid_intl_modes = ('none', 'small-icu', 'full-icu', 'system-icu')
5858
icu_versions = json.loads((tools_path / 'icu' / 'icu_versions.json').read_text(encoding='utf-8'))
59+
maglev_enabled_architectures = ('x64', 'arm', 'arm64')
5960

6061
shareable_builtins = {'cjs_module_lexer/lexer': 'deps/cjs-module-lexer/lexer.js',
6162
'cjs_module_lexer/dist/lexer': 'deps/cjs-module-lexer/dist/lexer.js',
@@ -812,11 +813,13 @@
812813
help='Enable V8 transparent hugepage support. This feature is only '+
813814
'available on Linux platform.')
814815

815-
parser.add_argument('--v8-enable-maglev',
816+
maglev_enabled_by_default_help = f"(Maglev is enabled by default on {','.join(maglev_enabled_architectures)})"
817+
818+
parser.add_argument('--v8-disable-maglev',
816819
action='store_true',
817-
dest='v8_enable_maglev',
820+
dest='v8_disable_maglev',
818821
default=None,
819-
help='Enable V8 Maglev compiler. Not available on all platforms.')
822+
help=f"Disable V8's Maglev compiler. {maglev_enabled_by_default_help}")
820823

821824
parser.add_argument('--v8-enable-short-builtin-calls',
822825
action='store_true',
@@ -1498,7 +1501,8 @@ def configure_v8(o):
14981501
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
14991502
o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
15001503
o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1
1501-
o['variables']['v8_enable_maglev'] = 1 if options.v8_enable_maglev else 0
1504+
o['variables']['v8_enable_maglev'] = B(not options.v8_disable_maglev and
1505+
o['variables']['target_arch'] in maglev_enabled_architectures)
15021506
o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0
15031507
o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0
15041508
o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression or options.disable_shared_ro_heap else 1

0 commit comments

Comments
 (0)
Please sign in to comment.