url: create href using searchParams without bindingUrl call

MattIPv4 · MattIPv4 · commit 3c5cb28b4240 · 2024-01-19T03:37:58.000Z
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -838,7 +838,9 @@ class URL {
   get href() {
     // URLSearchParams is used on demand, and stores the search if it's used.
     if (this.#searchParams) {
-      return bindingUrl.update(this.#context.href, updateActions.kSearch, this.#searchParams.toString());
+      return StringPrototypeSlice(this.#context.href, 0, this.#context.hash_start - 1)
+        + this.#searchParams.toString()
+        + StringPrototypeSlice(this.#context.href, this.#context.hash_start);
     }
     return this.#context.href;
   }

Original file line number	Diff line number	Diff line change
`@@ -838,7 +838,9 @@ class URL {`
`838`	`838`	`get href() {`
`839`	`839`	`// URLSearchParams is used on demand, and stores the search if it's used.`
`840`	`840`	`if (this.#searchParams) {`
`841`		`- return bindingUrl.update(this.#context.href, updateActions.kSearch, this.#searchParams.toString());`
	`841`	`+ return StringPrototypeSlice(this.#context.href, 0, this.#context.hash_start - 1)`
	`842`	`+ + this.#searchParams.toString()`
	`843`	`+ + StringPrototypeSlice(this.#context.href, this.#context.hash_start);`
`842`	`844`	`}`
`843`	`845`	`return this.#context.href;`
`844`	`846`	`}`