Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add latest brotli 1.1.0 bindings with compression dictionary support #52250

Closed
nhelfman opened this issue Mar 28, 2024 · 6 comments
Closed
Assignees
Labels
brotli Issues and PRs related to the brotli dependency. feature request Issues that request new features to be added to Node.js. stale

Comments

@nhelfman
Copy link

What is the problem this feature will solve?

Current node brotli compression does not support compression dictionary.
The dictionary option only supported for deflate/inflate according to documentation:

dictionary | | | (deflate/inflate only, empty dictionary by default)

This prevents using node.js directly to create compression dictionary diffs at build time which is necessary in order to adopt Compression dictionary transport

What is the feature you are proposing to solve the problem?

Add latest code/binaries and binding to compression options to support latest brotli (https://github.com/google/brotli) version 1.1.0 so that we can use the dictionary option in brotli.

cc: @benjamingr

What alternatives have you considered?

No response

@nhelfman nhelfman added the feature request Issues that request new features to be added to Node.js. label Mar 28, 2024
@VoltrexKeyva VoltrexKeyva added the brotli Issues and PRs related to the brotli dependency. label Mar 30, 2024
@benjamingr
Copy link
Member

@nodejs/zlib it looks like this just needs exposing in the API JS side

@juanarbol
Copy link
Member

I can work on this :-)

@MarshallOfSound
Copy link
Member

@juanarbol is this in flight somewhere, would love to poke at a dev branch or something 🤔 Poking at the compression dictionary transport tech and built in bindings would make this a lot easier 😅

Happy to help out with the change too 🥳

@avivkeller avivkeller moved this from Awaiting Triage to Triaged in Node.js feature requests Jun 26, 2024
Copy link
Contributor

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Mark issue so that it is never considered stale label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Dec 24, 2024
Copy link
Contributor

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2025
@alex-statsig
Copy link

@juanarbol / @avivkeller is there any update on this elsewhere? Seems like this was planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brotli Issues and PRs related to the brotli dependency. feature request Issues that request new features to be added to Node.js. stale
Projects
Archived in project
Development

No branches or pull requests

6 participants