-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add latest brotli 1.1.0 bindings with compression dictionary support #52250
Comments
@nodejs/zlib it looks like this just needs exposing in the API JS side |
I can work on this :-) |
@juanarbol is this in flight somewhere, would love to poke at a dev branch or something 🤔 Poking at the compression dictionary transport tech and built in bindings would make this a lot easier 😅 Happy to help out with the change too 🥳 |
There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the
never-stale
|
There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment. For more information on how the project manages feature requests, please consult the feature request management document. |
@juanarbol / @avivkeller is there any update on this elsewhere? Seems like this was planned |
What is the problem this feature will solve?
Current node brotli compression does not support compression dictionary.
The
dictionary
option only supported for deflate/inflate according to documentation:This prevents using node.js directly to create compression dictionary diffs at build time which is necessary in order to adopt Compression dictionary transport
What is the feature you are proposing to solve the problem?
Add latest code/binaries and binding to compression options to support latest brotli (https://github.com/google/brotli) version 1.1.0 so that we can use the
dictionary
option in brotli.cc: @benjamingr
What alternatives have you considered?
No response
The text was updated successfully, but these errors were encountered: