Wrong Typescript typings for http2.createSecureServer: missing streamResetBurst and streamResetRate in options

[gunters63]

Version

v23.8.0

Platform

Linux taubenus 6.12.16-1-cachyos-lts #1 SMP PREEMPT_DYNAMIC Sat, 22 Feb 2025 00:45:10 +0000 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

See also: #57169

With this merge request the docs were fixed, but the typings are still wrong.

To reproduce the problem:

import fs from 'node:fs';
import http2 from 'node:http2';

const key = fs.readFileSync('server.key');
const cert = fs.readFileSync('server.crt');

const server = http2.createSecureServer({
  key,
  cert,
  // Uncomment the following line to see the issue
  // @ts-expect-error missing types
  streamResetBurst: Number.MAX_SAFE_INTEGER,
  streamResetRate: Number.MAX_SAFE_INTEGER,
});

If you leave out the // @ts-expect-error comment Typescript will flag an error

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

The typings should be correct and the typescript error suppression comment not needed

What do you see instead?

Typescript flags an error about the documented and valid properties streamResetBurst and streamResetRate

Additional information

No response

[jakecastelli]

The PR fix towards #57169 was only a doc fix, if you want to fix the typing issue, you might need to fix here https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/http2.d.ts instead

[gunters63]

Ok, so I should close this issue and open one at DefinitelyTyped?