Skip to content

Commit 0a04f29

Browse files
authored
refactor: remove useless promise.all (#7629)
1 parent ca4c7a3 commit 0a04f29

File tree

1 file changed

+25
-29
lines changed

1 file changed

+25
-29
lines changed

apps/site/next-data/generators/releaseData.mjs

+25-29
Original file line numberDiff line numberDiff line change
@@ -33,45 +33,41 @@ const generateReleaseData = () => {
3333
// Basically those not in schedule.json
3434
const majors = Object.values(nodevuOutput).filter(major => !!major.support);
3535

36-
const nodeReleases = Promise.all(
37-
majors.map(async major => {
38-
const [latestVersion] = Object.values(major.releases);
36+
const nodeReleases = majors.map(major => {
37+
const [latestVersion] = Object.values(major.releases);
3938

40-
const support = {
41-
currentStart: major.support.phases.dates.start,
42-
ltsStart: major.support.phases.dates.lts,
43-
maintenanceStart: major.support.phases.dates.maintenance,
44-
endOfLife: major.support.phases.dates.end,
45-
};
39+
const support = {
40+
currentStart: major.support.phases.dates.start,
41+
ltsStart: major.support.phases.dates.lts,
42+
maintenanceStart: major.support.phases.dates.maintenance,
43+
endOfLife: major.support.phases.dates.end,
44+
};
4645

47-
// Get the major release status based on our Release Schedule
48-
const status = getNodeReleaseStatus(new Date(), support);
46+
// Get the major release status based on our Release Schedule
47+
const status = getNodeReleaseStatus(new Date(), support);
4948

50-
return {
51-
...support,
52-
status,
53-
major: latestVersion.semver.major,
54-
version: latestVersion.semver.raw,
55-
versionWithPrefix: `v${latestVersion.semver.raw}`,
56-
codename: major.support.codename || '',
57-
isLts: status === 'LTS',
58-
npm: latestVersion.dependencies.npm || '',
59-
v8: latestVersion.dependencies.v8 || '',
60-
releaseDate: latestVersion.releaseDate || '',
61-
modules: latestVersion.modules.version || '',
62-
};
63-
})
64-
);
49+
return {
50+
...support,
51+
status,
52+
major: latestVersion.semver.major,
53+
version: latestVersion.semver.raw,
54+
versionWithPrefix: `v${latestVersion.semver.raw}`,
55+
codename: major.support.codename || '',
56+
isLts: status === 'LTS',
57+
npm: latestVersion.dependencies.npm || '',
58+
v8: latestVersion.dependencies.v8 || '',
59+
releaseDate: latestVersion.releaseDate || '',
60+
modules: latestVersion.modules.version || '',
61+
};
62+
});
6563

6664
// nodevu returns duplicated v0.x versions (v0.12, v0.10, ...).
6765
// This behavior seems intentional as the case is hardcoded in nodevu,
6866
// see https://github.com/cutenode/nodevu/blob/0c8538c70195fb7181e0a4d1eeb6a28e8ed95698/core/index.js#L24.
6967
// This line ignores those duplicated versions and takes the latest
7068
// v0.x version (v0.12.18). It is also consistent with the legacy
7169
// nodejs.org implementation.
72-
return nodeReleases.then(releases =>
73-
releases.filter(r => r.major !== 0 || r.version === '0.12.18')
74-
);
70+
return nodeReleases.filter(r => r.major !== 0 || r.version === '0.12.18');
7571
});
7672
};
7773

0 commit comments

Comments
 (0)