You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: download button pointing to an incorrect binary on Windows arm64 (#7240)
* Fix Download button pointing to an incorrect binary on Windows arm64
Closes#7239
This PR changes the way DownloadButton calculates `bitness` which gets passed to `getNodeDownloadUrl`.
Previously, this value was passed directly from `useDetectOS()` without any further processing, leading to the issue mentioned above.
After this change, `bitness` is calculated similarly to how it's done in `BitnessDropdown`, so: by passing `architecture` and `bitness` to `getUserBitnessByArchitecture`:
https://github.com/nodejs/nodejs.org/blob/c5345f551ea545cf9d04017204b17f3099940ada/apps/site/components/Downloads/Release/BitnessDropdown.tsx#L16-L29
Signed-off-by: Wojciech Maj <[email protected]>
* Fix formatting
---------
Signed-off-by: Wojciech Maj <[email protected]>
0 commit comments