You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: COLLABORATOR_GUIDE.md
+3-4
Original file line number
Diff line number
Diff line change
@@ -277,7 +277,7 @@ Unit Tests are fundamental to ensure that code changes do not disrupt the functi
277
277
- We also recommend mocking external dependencies, if unsure about how to mock a particular dependency, raise the question on your Pull Request.
278
278
- We recommend using [Jest's Mock Functions](https://jestjs.io/docs/en/mock-functions) for mocking dependencies.
279
279
- We recommend using [Jest's Mock Modules](https://jestjs.io/docs/en/manual-mocks) for mocking dependencies unavailable on the Node.js runtime.
280
-
- Common Providers and Contexts from the lifecycle of our App, such as [`react-intl`][] should not be mocked but given an empty or fake context whenever possible.
280
+
- Common Providers and Contexts from the lifecycle of our App, such as [`next-intl`][] should not be mocked but given an empty or fake context whenever possible.
281
281
- We recommend reading previous unit tests from the codebase for inspiration and code guidelines.
282
282
283
283
### General Guidelines for Storybooks
@@ -340,7 +340,7 @@ This custom render uses `getStaticPaths` and [Incremental Static Generation](htt
340
340
For example, this allows us to generate Localized Pages for every page that is not translated, by telling Next.js to create a localised path.
341
341
`next.dynamic.mjs` is responsible for getting a full list of the source pages (`pages/en`) and identifying which pages have been translated.
342
342
343
-
Non-translated pages will have their Localized contexts and translated React message-bags (`react-intl`) but the content will be the same as the source page (English).
343
+
Non-translated pages will have their Localized contexts and translated React message-bags (`next-intl`) but the content will be the same as the source page (English).
344
344
Whereas localized pages will have localized context and content.
345
345
346
346
This custom solution is also able to decide what paths should be compiled during runtime.
@@ -491,12 +491,11 @@ If you're unfamiliar or curious about something, we recommend opening a Discussi
Copy file name to clipboardexpand all lines: DEPENDENCY_PINNING.md
+1-1
Original file line number
Diff line number
Diff line change
@@ -21,7 +21,7 @@ When adding dependencies, you should consider if that dependency should be saved
21
21
22
22
- A dependency, in general, should be pinned to its exact dependency if it's either a tooling or a CLI dependency. Examples include `husky`, `prettier`, `jest` and others.
23
23
- A dependency should generally use `~` if we're interested in patch updates (such as hot-fixes and bug-fixes) and the package is part of the Development or Testing Environment. (Such as `storybook`, for example)
24
-
- A dependency should generally use `^` if they're part of the Website Application itself, such as `react`, `react-intl` etc. This is done because we intentionally want to get these dependencies' latest features and bug-fixes.
24
+
- A dependency should generally use `^` if they're part of the Website Application itself, such as `react`, `next-intl` etc. This is done because we intentionally want to get these dependencies' latest features and bug-fixes.
25
25
- If we're not interested in getting the latest features and bug fixes, we should consider using `~` instead.
26
26
- Node. js-only dependencies used in scripts or during the build process of the Website (not used within actual Application code) should use `~` instead. Examples include `glob`, `@nodevu/core`
27
27
- TypeScript type packages of corresponding packages should follow the same `semver` of their respective packages
0 commit comments