Investigate recent Windows build failures

[bmuenzenmeyer]

See https://github.com/nodejs/nodejs.org/actions/runs/13079510033/job/36499592135?pr=7434 as an example

This does not happen locally for me. (Windows 10 Pro)

Chatter in Slack suggest this might be something that changed on GitHub's side. Perhaps with their runners.

Until we figure it out, or it resolves, this story or a subtask should remove Windows as a required check

[bmuenzenmeyer]

I've deleted build on windows-latest from https://github.com/nodejs/nodejs.org/settings/rules/10785

[bmuenzenmeyer]

cc @ovflowd

[benhalverson]

Here's another windows build failure https://github.com/nodejs/nodejs.org/actions/runs/13342497649/job/37269100891?pr=7497

[avivkeller]

Running the following commands:

npm i --no-audit --no-fund --userconfig=/dev/null --omit=dev  
npx --package=turbo@latest -- turbo build --force=true --cache-dir=.turbo/cache  

Results in the following error during prerendering:

@node-core/website:build: Error occurred prerendering page "/en/next-data/og/announcement/Run JavaScript Everywhere". Read more: https://nextjs.org/docs/messages/prerender-error  
@node-core/website:build: TypeError: Invalid URL  
@node-core/website:build:     at new URL (node:internal/url:818:25)  
@node-core/website:build:     at fileURLToPath (node:internal/url:1505:12)  
@node-core/website:build:     at file:///C:/nodejs.org/node_modules/next/dist/compiled/@vercel/og/index.node.js:18929:32  
@node-core/website:build:     at ModuleJob.run (node:internal/modules/esm/module_job:271:25)  
@node-core/website:build:     at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:578:26)  
@node-core/website:build:     at async Object.start (C:\nodejs.org\apps\site\.next\server\app\[locale]\next-data\og\[category]\[title]\route.js:1:6866)  

I was able to reproduce the issue and will investigate further.

⸻

The problematic line is from @vercel/og:

var fontData = fs.readFileSync(fileURLToPath(join(import.meta.url, "../noto-sans-v27-latin-regular.ttf")));

Changing it to the following would likely resolve the issue:

var fontData = fs.readFileSync(new URL("../noto-sans-v27-latin-regular.ttf", import.meta.url));

[avivkeller]

I see the issue. I think it's upstream, but essentially, on windows, join-ing a file:// url results in an invalid URL, but on Posix it doesn't.

Edit:

The issue is in @vercel/og, but that appears to be closed source. CC @styfle.

[avivkeller]

I've reached to Vercel explaining the issue, and will let you know what they say.

[mcollina]

You should not be manipulating file:// URLs with path.join().

[ovflowd]

You should not be manipulating file:// URLs with path.join().

It is not us. It is the @vercel/og package

[styfle]

This is fixed in vercel/next.js#77650 and should be available on next@canary shortly.

[avivkeller]

TYSM! We will update at the next Next.js release