Skip to content

Commit b4fc2f6

Browse files
RafaelGSSsxaUlisesGascon
authored
Apply suggestions from code review
Co-authored-by: Stewart X Addison <[email protected]> Co-authored-by: Ulises Gascón <[email protected]>
1 parent 9388551 commit b4fc2f6

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

MAINTAINERS_THREAT_MODEL.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ or inderictly (builds process/testing)
102102

103103
### Malicious release binary generation in Node.js release/build processes
104104

105-
In this scenario we assume that a malicious actor will include a malicios code
105+
In this scenario we assume that a malicious actor will include a malicious code
106106
(malware, malicious dependencies, polluted binaries...) in the release binaries
107107
available through the Nodejs.org downloads.
108108

@@ -114,7 +114,7 @@ for the tooling/build repositories (like ansible scripts, etc..)
114114
Jenkins/GH Actions
115115
* Manipulate the CI/release pipelines in Jenkins or GH Actions (add/modify custom
116116
scripts, pollute plugins, overwrite configuration...)
117-
* Swaping out release binaries where they are hosted on nodejs.org web server
117+
* Swapping out release binaries where they are hosted on nodejs.org web server
118118
* Modifying the cloudflare configuration to change were binaries are served from
119119
* Modifying the vercel website configation
120120

@@ -167,16 +167,17 @@ Notes:
167167
| **private/secrets** | r | read access to secrets grants access to key resources |
168168
| **nodejs/node** | - | N\A |
169169
| **nodejs/deps¹** | - | N\A |
170-
| **nodejs/build** (GH) | w | write access would allow key scripts, infra to be modified |
170+
| **nodejs/build** (GH) | - | N\A |
171+
| **nodejs/unofficial-builds** (GH) | w | write access would allow key scripts, infra to be modified |
171172
| **nodejs/docker-node** | w | modification of Docker files can modify what node.js binaries are in the images
172173
| **nodejs/node-core-utils** | - | N\A |
173174
| **npm account** | - | N\A |
174175
| **Jenkins CI - test** | - | N\A |
175-
| **Jenkins CI - release** | w | access to jenkins used for build would allow swapping published binaries |
176+
| **Jenkins CI - release** | - | N\A |
176177
| **Infra - test** | - | N/A |
177-
| **Infra - release** | w | access to machines used for build would allow swapping published binaries |
178-
| **Build infra** | w | access to machines used for build would allow swapping published binaries |
179-
| **Website Infra** | w | access to machines used for build would allow swapping published binaries |
178+
| **Infra - release** | - | N\A |
179+
| **Build infra** | w | access to machine used for unofficial-builds as server |
180+
| **Website Infra** | - | N\A |
180181
| **Youtube** | - | N\A |
181182
| **Zoom** | - | N\A |
182183
| **1Password** | r | read access to secrets grants access to key resources |

0 commit comments

Comments
 (0)