fix: do not throw unhandled exception when data is undefined in interceptor.reply

Author: frederikprijck

lib/mock/mock-utils.js

@@ -124,8 +124,10 @@ function getResponseData (data) {
     return data
   } else if (typeof data === 'object') {
     return JSON.stringify(data)
-  } else {
+  } else if (data) {
     return data.toString()
+  } else {
+    return ''
   }
 }
 

test/mock-interceptor.js

@@ -107,6 +107,46 @@ describe('MockInterceptor - reply options callback', () => {
     })
   })
 
+  test('should handle undefined data', t => {
+    t = tspl(t, { plan: 2 })
+
+    const mockInterceptor = new MockInterceptor({
+      path: '',
+      method: ''
+    }, [])
+    const result = mockInterceptor.reply((options) => ({
+      statusCode: 200,
+      data: undefined
+    }))
+    t.ok(result instanceof MockScope)
+
+    // Test parameters
+
+    const baseUrl = 'http://localhost:9999'
+    const mockAgent = new MockAgent()
+    after(() => mockAgent.close())
+
+    const mockPool = mockAgent.get(baseUrl)
+
+    mockPool.intercept({
+      path: '/test',
+      method: 'GET'
+    }).reply((options) => {
+      t.deepStrictEqual(options, { path: '/test', method: 'GET', headers: { foo: 'bar' } })
+      return { statusCode: 200, data: 'hello' }
+    })
+
+    mockPool.dispatch({
+      path: '/test',
+      method: 'GET',
+      headers: { foo: 'bar' }
+    }, {
+      onHeaders: () => { },
+      onData: () => { },
+      onComplete: () => { }
+    })
+  })
+
   test('should error if passed options invalid', async (t) => {
     t = tspl(t, { plan: 4 })
 

test/mock-utils.js

@@ -174,6 +174,12 @@ describe('getResponseData', () => {
     const responseData = getResponseData(new TextEncoder().encode('{"test":true}').buffer)
     t.ok(responseData instanceof ArrayBuffer)
   })
+
+  test('it should handle undefined', (t) => {
+    t = tspl(t, { plan: 1 })
+    const responseData = getResponseData(undefined)
+    t.strictEqual(responseData, '')
+  })
 })
 
 test('getStatusText', (t) => {