Commit a9dd289
authored
cleaner selection get methods (#199)
Split the new qid-getting method back off
<!-- ELLIPSIS_HIDDEN -->
----
> [!IMPORTANT]
> Refactor `get()` method in `DataSelection` and `SortedDataSelection` by splitting logic into `get()`, `getQid()`, and `getBase()` for improved clarity.
>
> - **Refactoring**:
> - Split `get()` method in `DataSelection` and `SortedDataSelection` into `get()`, `getQid()`, and `getBase()` for clarity.
> - `get()` now calls `getBase()` with `returnQid` set to `false`.
> - `getQid()` added to return a tuple of `[tile index, row index]` by calling `getBase()` with `returnQid` set to `true`.
> - `getBase()` contains the core logic for retrieving elements based on index.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=nomic-ai%2Fdeepscatter&utm_source=github&utm_medium=referral)<sup> for 8489ba4. You can [customize](https://app.ellipsis.dev/nomic-ai/settings/summaries) this summary. It will automatically update as commits are pushed.</sup>
<!-- ELLIPSIS_HIDDEN -->1 parent 96728d5 commit a9dd289
1 file changed
Lines changed: 46 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
798 | 798 | | |
799 | 799 | | |
800 | 800 | | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
801 | 818 | | |
802 | | - | |
803 | | - | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
804 | 826 | | |
805 | | - | |
806 | | - | |
807 | | - | |
808 | | - | |
809 | | - | |
810 | | - | |
811 | | - | |
812 | | - | |
813 | | - | |
814 | | - | |
815 | | - | |
816 | | - | |
| 827 | + | |
817 | 828 | | |
818 | 829 | | |
819 | 830 | | |
| |||
847 | 858 | | |
848 | 859 | | |
849 | 860 | | |
850 | | - | |
851 | | - | |
852 | | - | |
853 | | - | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
854 | 866 | | |
855 | 867 | | |
856 | 868 | | |
| |||
1112 | 1124 | | |
1113 | 1125 | | |
1114 | 1126 | | |
1115 | | - | |
1116 | | - | |
1117 | 1127 | | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
1118 | 1135 | | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
1119 | 1144 | | |
1120 | 1145 | | |
1121 | 1146 | | |
1122 | 1147 | | |
1123 | | - | |
| 1148 | + | |
1124 | 1149 | | |
1125 | 1150 | | |
1126 | 1151 | | |
| |||
0 commit comments