NSFS | Disabling rate-limiting for Rsyslog is not recommended

[naveenpaul1]

Environment info

• NooBaa Version: VERSION
• Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

1. Disabling rate limit for rsyslog will result into denial-of-service.

$imjournalRatelimitInterval 0
$imjournalRatelimitBurst 0

Its mentioned in Redhat official document

As with systemd-journald, disabling rate-limiting altogether is not recommended. Note the following:
Warning: Some versions of journald have problems with database corruption, which leads to the journal returning the same data endlessly in a tight loop. This can result in a large number of log messages getting duplicated inside the logs managed by rsyslog. It can also lead to denial-of-service if this results in 100% CPU or memory usage. 

doc : https://access.redhat.com/solutions/1417483

Expected behavior

1. Need to identify best Noobaa configuration for both imjournalRatelimitInterval and imjournalRatelimitBurst

Steps to reproduce

More information - Screenshots / Logs / Other output

[naveenpaul1]

@guymguym @romayalon In Redhat doc it mentioned that disabling rate-limiting altogether is not recommended, And I was trying to find a more reasonable configuration for Noobaa logs. With NOOBAA_LOG_LEVEL all following warp create more than 300,000 log entries and the file size is 65Mb

./warp get --host=localhost:6443 --obj.size=10Mb  --concurrent=5  --duration=5m --bucket=bucket1 --insecure --tls

With this rate, Noobaa generates 60,000 logs/30s, And we can use this configuration to control the log rate.

$imjournalRatelimitInterval 30
$imjournalRatelimitBurst 60000

I am not sure if is this a valid benchmark for testing. Could you please let me know if this is enough or try with a different data set. WDYT?

[github-actions]

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

[github-actions]

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

[github-actions]

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.