Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | List Objects | Make List Objects More Robust and Additionl Gaps #8845

Open
shirady opened this issue Mar 3, 2025 · 0 comments
Open
Labels

Comments

@shirady
Copy link
Contributor

shirady commented Mar 3, 2025

Environment info

  • NooBaa Version: 5.19.0
  • Platform: NC

Actual behavior

  1. Currently (master) if an entry had EACCES on stat this entry is ignored. In other words, the list would not contain this key (as added in PR NC | Multi Protocol Access | List object with conflicting ownership #8751).
  2. Currently, if an entry had ELOOP or ENAMETOOLONG on stat this entry is ignored. In other words, the list would not contain this key.
  3. After PR NSFS | Fix Bug | Race Between List Object and Delete Object #8809 will be merged, that stat is called in a serial way.

More general

  1. After PR NSFS | Fix Bug | Race Between List Object and Delete Object #8809 will be merged, we might look at all the cases where we used stat and think if we want to change the call to stat_if_exists.
  2. Handling EPREM when extended attributes feature is not supported in the FS.

Expected behavior and suggestion (the numbers are adjusted to the title before)

  1. We might want to add this key in the list. Therefore, we will need to change the stat that we use, currently in fs_napi we use the open system call inside for the extended attributes, but we may consider changing it so we can stat without open, we can also consider changing the context so the list objects will be by root.
  2. We need to discuss if we want to ignore those errors as they can appear in FS cross protocol.
  3. We need to think if we can somehow make the calls concurrent.

Steps to reproduce

  1. list object in NSFS.

More information - Screenshots / Logs / Other output

none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant