Initial commit.

Author: bnekolny

.env

@@ -0,0 +1 @@
+PORT=8080

.gitignore

@@ -0,0 +1 @@
+*.swp

Dockerfile

@@ -0,0 +1,12 @@
+FROM golang:1.13-alpine as build
+RUN apk add git
+RUN go get github.com/securego/gosec/cmd/gosec/...
+RUN go get github.com/githubnemo/CompileDaemon
+ADD . /app
+WORKDIR /app
+RUN go build -o code-challenge-golang .
+
+FROM alpine as app
+COPY --from=build /app/code-challenge-golang /app/
+WORKDIR /app
+CMD ["./code-challenge-golang"]

README.md

@@ -0,0 +1,49 @@
+# Brandfolder Code-Challenge-Golang
+
+### Requirements
+- Docker Compose
+
+### How to get started
+Given the need to pull some docker containers, it'd be beneficial to start that process:
+```
+docker-compose up
+```
+
+
+This repository represents an application that accepts a list of files via a 
+```
+POST /download 
+[
+  {
+    "filename": "fname.png",
+    "url": "https://url.com/to/file.png",
+    "gcsUrl": "gs://bucketname/path/to/file.png"  # Optional
+  }.
+  ...
+]
+```
+
+The repo in it's entirely contains a few components (loadgen-server, main.go, dependency-server). Here is a Flow Diagram that depicts the lifecycle of the repo.
+
+![Flow Diagram](https://www.websequencediagrams.com/cgi-bin/cdraw?lz=dGl0bGUgY29kZS1jaGFsbGVuZ2UtZ29sYW5nIGFwcGxpY2F0aW9uIGZsb3cgZGlhZ3JhbQoKcGFydGljaXBhbnQgbG9hZGdlbi1zZXJ2ZXIADg1uZ2lueAAgDQBUFQATD250ZW50CgoASg4tPisAgRAVOiByZXF1ZXN0IGxpc3Qgb2YgZmlsZXMKbG9vcAAGBQogAIFIFgBMBQBmBTogZmV0Y2gAJAoAfAUtLT4tAFsXc3RyZWFtAFgGZW5kCgBKFi0-LQCCDQ4AMAl6aXA&s=default)
+
+
+The responsibility of the application under question is contained within the `main.go` application. It's responsibility is to decode the request (list of files), compile them into a zip, and stream them to the client.
+
+This service has a mixture of end-users, and it's importance and footprint has grown. We're starting to hear that there are errors in the functionality delivered to end-users, and would like help debugging and correcting some of the errors.
+
+In the midst of this work, please make an effort to make logical improvements to the service and up-level our practices. Do your best to describe your intentions and coach us as team members on how we should think about making changes.
+
+### Goal of this exercise
+1. Help us identify the effectiveness/failures of this service
+   1. Suggestion of how this could be quantified/monitored
+1. Make changes to reduce the failure rate
+1. Suggest and possibly implement structural changes to the code for better maintainability
+
+Open main.go for assessing code footpring and editing
+
+### Commands to help
+```
+docker-compose logs -f nginx
+docker-compose logs -f code-challenge-golang
+```

code-challenge-golang

@@ -0,0 +1,10 @@
+FROM golang:1.13-alpine as build
+RUN apk add git
+RUN go get github.com/githubnemo/CompileDaemon
+ADD . /app
+WORKDIR /app
+RUN go build -o dependent-server .
+
+FROM alpine as app
+COPY --from=build /app/dependent-server /app/
+CMD ["/app/dependent-server"]

dependent-server/Dockerfile

@@ -0,0 +1,85 @@
+package main
+
+// http server that logs requests and allows clients to define response duration and returned status code.
+//
+// Examples:
+//   # return a response after 10 minutes with a 500 status code
+//   curl <host>/?duration=10m&statusCode=500
+//
+//   # return a response after 20 seconds with a 201 status code
+//   curl <host>/?duration=10m&statusCode=500
+//
+//   # return a response immediately with a 200 status code (defaults)
+//   curl <host>/
+
+import (
+	"fmt"
+	"io/ioutil"
+	"log"
+	"net/http"
+	"os"
+	"strconv"
+	"time"
+)
+
+func handler(w http.ResponseWriter, r *http.Request) {
+	//log.Print("echo server received a request")
+
+	query := r.URL.Query()
+	statusCode := query.Get("statusCode")
+	duration := query.Get("duration")
+
+	body, err := ioutil.ReadAll(r.Body)
+	if err != nil {
+		//log.Printf("error reading body: %v", err)
+		return
+	}
+
+	if len(body) > 0 {
+		//log.Printf("body received: %v", string(body))
+	}
+
+	if duration != "" {
+		d, err := time.ParseDuration(duration)
+		if err != nil {
+			msg := fmt.Sprintf("invalid duration: %v", duration)
+			//log.Print(msg)
+			w.WriteHeader(http.StatusBadRequest)
+			_, _ = w.Write([]byte(msg))
+			return
+		}
+		//log.Printf("sleeping requested duration: %v", d)
+		time.Sleep(d)
+	}
+
+	if statusCode != "" {
+		s, err := strconv.Atoi(statusCode)
+		if err != nil {
+			msg := fmt.Sprintf("invalid statusCode: %v", statusCode)
+			//log.Print(msg)
+			w.WriteHeader(http.StatusBadRequest)
+			_, _ = w.Write([]byte(msg))
+			return
+		}
+		w.WriteHeader(s)
+        if s == 200 {
+            log.Println("printing image")
+            w.Write([]byte{137, 80, 78, 71, 13, 10, 26, 10, 0, 0, 0, 13, 73, 72, 68, 82, 0, 0, 0, 1, 0, 0, 0, 1, 8, 2, 0, 0, 0, 144, 119, 83, 222, 0, 0, 0, 12, 73, 68, 65, 84, 8, 215, 99, 216, 122, 225, 2, 0, 4, 147, 2, 86, 234, 93, 183, 214, 0, 0, 0, 0, 73, 69, 78, 68, 174, 66, 96, 130})
+        }
+		return
+	}
+	w.WriteHeader(http.StatusOK)
+}
+
+func main() {
+	//log.Print("echo server started")
+
+	http.HandleFunc("/", handler)
+
+	port := os.Getenv("PORT")
+	if port == "" {
+		port = "8080"
+	}
+
+	log.Fatal(http.ListenAndServe(fmt.Sprintf(":%s", port), nil))
+}

dependent-server/dependent-server

@@ -0,0 +1,56 @@
+version: "3.7"
+services:
+  code-challenge-golang:
+    build:
+      target: build
+      context: .
+    env_file:
+      - .env
+    volumes:
+      - .:/app
+    ports:
+      - 8080:8080
+    command:
+      CompileDaemon -directory="/app" -build="go build -o code-challenge-golang ." -command="/app/code-challenge-golang"
+    networks:
+      - internal-network
+      - dependent-network
+    depends_on:
+      - dependent-server
+  nginx:
+    image: nginx:latest
+    volumes:
+      - ./nginx.conf:/etc/nginx/nginx.conf
+    ports:
+      - 80:80
+    networks:
+      - internal-network
+    depends_on:
+      - code-challenge-golang
+  dependent-server:
+    build:
+      context: dependent-server
+      target: build
+    environment:
+      - PORT=8090
+    ports:
+      - 8090:8090
+    volumes:
+      - ./dependent-server:/app
+    command:
+      CompileDaemon -directory="/app" -build="go build -o dependent-server ." -command="/app/dependent-server"
+    networks:
+      - dependent-network
+  loadgen-server:
+    build:
+      context: loadgen-server
+    volumes:
+      - ./loadgen-server:/app
+    networks:
+      - internal-network
+    command:
+      python make_requests.py
+
+networks:
+  internal-network:
+  dependent-network:

dependent-server/main.go

@@ -0,0 +1,5 @@
+module github.com/brandfolder/code-challenge-golang
+
+go 1.13
+
+require cloud.google.com/go/storage v1.5.0