point type to hold x, y coord

Author: RedArcaneArcher

fov/fov.go

@@ -6,7 +6,6 @@ expected of any grid-based implementation
 package fov
 
 import (
-	"fmt"
 	"math"
 )
 
@@ -17,9 +16,14 @@ type GridMap interface {
 	IsOpaque(x, y int) bool
 }
 
+//point to hold a x, y position
+type point struct {
+	x, y int
+}
+
 // gridSet is an efficient and idiomatic way to implement sets in go, as an empty struct takes up no space
 // and nothing more than a set of keys is needed to store the range of visible cells
-type gridSet map[string]struct{}
+type gridSet map[point]struct{}
 
 // View is the item which stores the visible set of cells any time it is called. This should be called any time
 // a player's position is updated
@@ -35,8 +39,8 @@ func New() *View {
 // Compute takes a GridMap implementation along with the x and y coordinates representing a player's current
 // position and will internally update the visibile set of tiles within the provided radius `r`
 func (v *View) Compute(grid GridMap, px, py, radius int) {
-	v.Visible = make(map[string]struct{})
-	v.Visible[fmt.Sprintf("%d,%d", px, py)] = struct{}{}
+	v.Visible = make(map[point]struct{})
+	v.Visible[point{px, py}] = struct{}{}
 	for i := 1; i <= 8; i++ {
 		v.fov(grid, px, py, 1, 0, 1, i, radius)
 	}
@@ -65,7 +69,7 @@ func (v *View) fov(grid GridMap, px, py, dist int, lowSlope, highSlope float64,
 		if grid.InBounds(mapx, mapy) && distTo(px, py, mapx, mapy) < rad {
 			// As long as a tile is within the bounds of the map, if we visit it at all, it is considered visible
 			// That's the efficiency of shadowcasting, you just dont visit tiles that aren't visible
-			v.Visible[fmt.Sprintf("%d,%d", mapx, mapy)] = struct{}{}
+			v.Visible[point{mapx, mapy}] = struct{}{}
 		}
 
 		if grid.InBounds(mapx, mapy) && grid.IsOpaque(mapx, mapy) {
@@ -90,7 +94,7 @@ func (v *View) fov(grid GridMap, px, py, dist int, lowSlope, highSlope float64,
 // IsVisible takes in a set of x,y coordinates and will consult the visible set (as a gridSet) to determine
 // whether that tile is visible.
 func (v *View) IsVisible(x, y int) bool {
-	if _, ok := v.Visible[fmt.Sprintf("%d,%d", x, y)]; ok {
+	if _, ok := v.Visible[point{x, y}]; ok {
 		return true
 	}
 	return false
@@ -117,4 +121,4 @@ func distTo(x1, y1, x2, y2 int) int {
 	vx := math.Pow(float64(x1-x2), 2)
 	vy := math.Pow(float64(y1-y2), 2)
 	return int(math.Sqrt(vx + vy))
-}
+}