Add disconnect method and fix up Network class #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
serf.disconnect
method that closes the underlying socket, allowing node to gracefully exit.Also fixes up the network class a bit:
Network.connect
callback more than once. This was being called both after connecting and on any socket errors (thenet.on("error"...)
handler wasn't actually handling connection errors).(Trying to submit small, isolated PRs, but to do the rest of #5 it will be rather invasive.)